Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve contributor workflow #616

Merged
merged 6 commits into from
Jan 27, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: more robus check for driver ready
Ensure all previous pods are gone from the api.

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
  • Loading branch information
tiagolobocastro committed Jan 22, 2025
commit 15160aabd22f17b8d4809ba783f33de2cfee5381
9 changes: 6 additions & 3 deletions ci/ci-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ cleanup_loop_zfs() {

sudo "$(which zpool)" destroy -f zfspv-pool || :
sudo losetup -d "$device" 2>/dev/null || :
rm "/tmp/disk.img"
rm "/tmp/disk.img" || :
done
}

Expand All @@ -78,6 +78,8 @@ cleanup() {
# shellcheck disable=SC2086
kubectl delete crds $CRDS_TO_DELETE_ON_CLEANUP
kubectl delete -f "${SNAP_CLASS}"

kubectl delete pod -lrole=openebs-zfs --force -n "$OPENEBS_NAMESPACE"
fi
fi

Expand Down Expand Up @@ -139,7 +141,8 @@ dump_logs() {
}

isPodReady(){
[ "$(kubectl get po "$1" -o 'jsonpath={.status.conditions[?(@.type=="Ready")].status}' -n "$OPENEBS_NAMESPACE")" = 'True' ]
[ "$(kubectl get po "$1" -o 'jsonpath={.status.conditions[?(@.type=="Ready")].status}' -n "$OPENEBS_NAMESPACE")" = 'True' ] &&
[ "$(kubectl get po "$1" -o 'jsonpath={.metadata.deletionTimestamp}' -n "$OPENEBS_NAMESPACE")" = "" ]
}

isDriverReady(){
Expand Down Expand Up @@ -177,7 +180,7 @@ helm_install() {

waitForZFSDriver

kubectl get po -n "$OPENEBS_NAMESPACE"
kubectl get pods -n "$OPENEBS_NAMESPACE"
}

runTestSuite() {
Expand Down
2 changes: 1 addition & 1 deletion vm.nix
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ in
enable = true;
config = {
safe = {
directory = [ "/zfs" "/zfs/nix/.go/src/github.com/kubernetes-csi/csi-test/" "/zfs/nix/.go/src/github.com/kubernetes-csi/csi-test/.git" ];
directory = [ "/zfs" "/zfs/nix/.go/src/github.com/kubernetes-csi/csi-test" "/zfs/nix/.go/src/github.com/kubernetes-csi/csi-test/.git" ];
};
};
};
Expand Down
Loading