docs: improve contributor workflow #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6a4c17b to
ab6644a
Compare
feffb8a to
d4bcbea
Compare
Use cli arguments to control cleanup rather than using env variables which are more obscure. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Makes it the same as the lvm-localpv. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Adds a nixos shell for local testing. This a headless vm with zfs installed and configured for testing, as well as being a single node k3s cluster. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Lint contributing doc Improve development setup guide, including the nixos-shell k3s docs Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
d4bcbea to
a52a7ce
Compare
Ensure all previous pods are gone from the api. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
7f9f3b8 to
15160aa
Compare
Abhinandan-Purkait
approved these changes
Jan 27, 2025
sinhaashish
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
I had a bit of trouble running the tests and getting them to pass recently.
We can improve things.
What this PR does?:
Improves on the existing documentation.
Facilitates testing with a no-frills ready-made zfs.
Does this PR require any upgrade changes?:
No
Checklist:
<type>(<scope>): <subject>