Merge pull request #524 from zdtsw-forking/fix/path2

Fix: downstream workbranch to get imageparams
opendatahub-io · Sep 8, 2023 · 6bfe048 · 6bfe048
2 parents b32f1f3 + 571cda5
commit 6bfe048
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/components/workbenches/workbenches.go b/components/workbenches/workbenches.go
@@ -82,8 +82,14 @@ func (w *Workbenches) ReconcileComponent(owner metav1.Object, cli client.Client,
 	// Update image parameters for notebook image
 	if enabled {
 		if dscispec.DevFlags.ManifestsUri == "" {
-			if err := deploy.ApplyImageParams(notebookImagesPath, imageParamMap); err != nil {
-				return err
+			if platform == deploy.OpenDataHub || platform == "" {
+				if err := deploy.ApplyImageParams(notebookImagesPath, imageParamMap); err != nil {
+					return err
+				}
+			} else {
+				if err := deploy.ApplyImageParams(notebookImagesPathSupported, imageParamMap); err != nil {
+					return err
+				}
 			}
 		}
 	}