Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: downstream workbranch to get imageparams #524

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Sep 8, 2023

Description

when test downstream, got error:

2023-09-08T13:19:56Z ERROR controllers.DataScienceCluster failed to reconcile workbenches on DataScienceCluster {"instance.Name": "default", "error": "error during resmap resources: must build at directory: not a valid directory: evalsymlink failure on '/opt/manifests/notebook-images/overlays/additional/default' : lstat /opt/manifests/notebook-images: no such file or directory"}

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@openshift-ci openshift-ci bot requested review from etirelli and LaVLaS September 8, 2023 13:32
@zdtsw zdtsw requested review from VaishnaviHire and removed request for LaVLaS September 8, 2023 13:32
Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 8, 2023
@zdtsw zdtsw enabled auto-merge September 8, 2023 13:41
@zdtsw zdtsw merged commit 6bfe048 into opendatahub-io:main Sep 8, 2023
@zdtsw zdtsw deleted the fix/path2 branch June 22, 2024 12:05
grdryn pushed a commit to grdryn/opendatahub-operator that referenced this pull request Nov 28, 2024
- dsp has change on 2.16 release branch
- Operator need to get new manifests from there

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants