Skip to content

Commit

Permalink
Fix: downstream workbranch to get imageparams
Browse files Browse the repository at this point in the history
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
  • Loading branch information
zdtsw committed Sep 8, 2023
1 parent b32f1f3 commit 571cda5
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions components/workbenches/workbenches.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,14 @@ func (w *Workbenches) ReconcileComponent(owner metav1.Object, cli client.Client,
// Update image parameters for notebook image
if enabled {
if dscispec.DevFlags.ManifestsUri == "" {
if err := deploy.ApplyImageParams(notebookImagesPath, imageParamMap); err != nil {
return err
if platform == deploy.OpenDataHub || platform == "" {
if err := deploy.ApplyImageParams(notebookImagesPath, imageParamMap); err != nil {
return err
}
} else {
if err := deploy.ApplyImageParams(notebookImagesPathSupported, imageParamMap); err != nil {
return err
}
}
}
}
Expand Down

0 comments on commit 571cda5

Please sign in to comment.