feat: Add Data catalog components #32
Conversation
85a1a19 to
1738f07
Compare
|
@cfchase this can be reviewed and merged now, we have datacatalog fully merged to the |
| description: "Expose Spark data frames modeled as Hive tables through a JDBC connection", | ||
| kfdefApplications: ["thriftserver"], | ||
| route: "thriftserver", | ||
| img: "images/spark.svg", |
There was a problem hiding this comment.
@tumido This is probably ok for now, but I think we don't really want 2 tiles with the exact same icon. Perhaps we can engage @kywalker-rh about what icon he'd like to use. Maybe we can overlay a SQL icon over Spark or something.
There was a problem hiding this comment.
Yeah.. the problem is that Thrift Server by itself doesn't have it's own icon/logo. They use the Spark logo instead. Which is unfortunate. 🙂
There was a problem hiding this comment.
Thanks for adding me @cfchase. You're right, its not ideal to have more than one tile with the same icon, but its probably okay for now. Thinking it through, if we had more than one product from the same company, say two services from Red Hat, or Anaconda, they would probably have the same icon too, though, so maybe its not a big deal at all. But I will ask around and see if there are other instances on other projects that we'd want to emulate for a situation like this.
There was a problem hiding this comment.
I just confirmed this is a fairly common issue with other products, so as long as the card title and description will be different to help users understand Spark is different from Thrift Server, we should be fine.
Enables Data catalog components in Dashboard
Requires:
opendatahub-io/odh-manifests#228
opendatahub-io/odh-manifests#227