Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Data catalog components #32

Merged
merged 1 commit into from
Jan 20, 2021
Merged

feat: Add Data catalog components #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions frontend/public/images/hue.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
18 changes: 18 additions & 0 deletions routes/api/components/available-components.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,22 @@ module.exports = [
img: "images/airflow.svg",
docsLink: "https://airflow.apache.org/",
},
{
key: "hue",
label: "Hue",
description: "Data exploration platform for Hive and S3 storage",
kfdefApplications: ["hue"],
route: "hue",
img: "images/hue.svg",
docsLink: "https://docs.gethue.com/",
},
{
key: "thriftserver",
label: "Spark SQL Thrift Server",
description: "Expose Spark data frames modeled as Hive tables through a JDBC connection",
kfdefApplications: ["thriftserver"],
route: "thriftserver",
img: "images/spark.svg",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tumido This is probably ok for now, but I think we don't really want 2 tiles with the exact same icon. Perhaps we can engage @kywalker-rh about what icon he'd like to use. Maybe we can overlay a SQL icon over Spark or something.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.. the problem is that Thrift Server by itself doesn't have it's own icon/logo. They use the Spark logo instead. Which is unfortunate. 🙂

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding me @cfchase. You're right, its not ideal to have more than one tile with the same icon, but its probably okay for now. Thinking it through, if we had more than one product from the same company, say two services from Red Hat, or Anaconda, they would probably have the same icon too, though, so maybe its not a big deal at all. But I will ask around and see if there are other instances on other projects that we'd want to emulate for a situation like this.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just confirmed this is a fairly common issue with other products, so as long as the card title and description will be different to help users understand Spark is different from Thrift Server, we should be fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FFR, tracked at #36

docsLink: "https://spark.apache.org/docs/latest/sql-distributed-sql-engine.html",
}
];