-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add dashboard #42
Conversation
@durandom would you rather see it forked into this GH organization + use some shared quay repo instead of my account or is it fine with you for the time being... I personally don't care, though it might take a while before ODH dashboard supports our usecase |
@tumido can you push the image to a more official location? Is there an operatefirst repo on quay? |
Let's keep it simple and in @tumido fork and quay. @HumairAK can you review and merge? @HumairAK @tumido @anishasthana can you start a discussion on best practice for this scenario, where we deploy a fork? |
kfdef/dashboard/overrides/overlays/custom-image/kustomization.yaml
Outdated
Show resolved
Hide resolved
0c314c2
to
9d751ef
Compare
I snagged an operate-first quay org some time ago for this usecase, let's store our fork images there while we work towards getting this stuff upstream : https://quay.io/organization/operate-first/ and yes we should include this as part of an adr, but to keep this unblocked, let's get the image updated to this repo instead of your user one: https://quay.io/organization/operate-first/ |
I've moved the image to https://quay.io/repository/operate-first/odh-dashboard?tab=tags manifests should be updated as well. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#10 -- related |
Resolves: #12
Deploys a fork of the ODH Dashboard with following patches applied:
This is baked into a custom image at https://quay.io/repository/tcoufal/odh-dashboard
Additionally to that it deploys a
ClusterRole
with aClusterRoleBinding
, allowingodh-dashboard
service account to look up all the namespaces and consumekfdef
resouces from them.Example:
Here you can see Argo running at
opf-argo
and Hue with Thrift server running atopf-datacatalog
. All located successfully, with routes as well.