Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dashboard #42

Merged
merged 1 commit into from
Dec 2, 2020
Merged

feat: Add dashboard #42

merged 1 commit into from
Dec 2, 2020

Conversation

tumido
Copy link
Member

@tumido tumido commented Dec 2, 2020

Resolves: #12

Deploys a fork of the ODH Dashboard with following patches applied:

This is baked into a custom image at https://quay.io/repository/tcoufal/odh-dashboard

Additionally to that it deploys a ClusterRole with a ClusterRoleBinding, allowing odh-dashboard service account to look up all the namespaces and consume kfdef resouces from them.

Example:
image
Here you can see Argo running at opf-argo and Hue with Thrift server running at opf-datacatalog. All located successfully, with routes as well.

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 2, 2020
@tumido
Copy link
Member Author

tumido commented Dec 2, 2020

/cc @durandom @HumairAK

@sesheta sesheta requested review from durandom and HumairAK December 2, 2020 16:13
@tumido
Copy link
Member Author

tumido commented Dec 2, 2020

@durandom would you rather see it forked into this GH organization + use some shared quay repo instead of my account or is it fine with you for the time being... I personally don't care, though it might take a while before ODH dashboard supports our usecase

@anishasthana
Copy link
Member

@tumido can you push the image to a more official location? Is there an operatefirst repo on quay?

@durandom
Copy link
Member

durandom commented Dec 2, 2020

Let's keep it simple and in @tumido fork and quay.

@HumairAK can you review and merge?

@HumairAK @tumido @anishasthana can you start a discussion on best practice for this scenario, where we deploy a fork?
I guess this should work in conjunction with upstream to create images of PRs in their pipeline
Maybe start the discussion as an ADR pull request

@tumido tumido force-pushed the dashboard branch 2 times, most recently from 0c314c2 to 9d751ef Compare December 2, 2020 17:09
@sesheta sesheta added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2020
@HumairAK
Copy link
Member

HumairAK commented Dec 2, 2020

I snagged an operate-first quay org some time ago for this usecase, let's store our fork images there while we work towards getting this stuff upstream : https://quay.io/organization/operate-first/

and yes we should include this as part of an adr, but to keep this unblocked, let's get the image updated to this repo instead of your user one: https://quay.io/organization/operate-first/
@durandom wdyt?

@tumido
Copy link
Member Author

tumido commented Dec 2, 2020

I've moved the image to https://quay.io/repository/operate-first/odh-dashboard?tab=tags manifests should be updated as well.

@tumido tumido requested a review from anishasthana December 2, 2020 17:30
@tumido tumido requested a review from HumairAK December 2, 2020 17:30
@sesheta
Copy link
Member

sesheta commented Dec 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
@sesheta sesheta merged commit 520c4ad into operate-first:master Dec 2, 2020
@HumairAK
Copy link
Member

HumairAK commented Dec 2, 2020

#10 -- related

@tumido tumido deleted the dashboard branch November 2, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ODH dashboard
5 participants