Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TE-3:7: make sure ni key 'name' is configured #2590

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

kjahed
Copy link
Contributor

@kjahed kjahed commented Jan 29, 2024

Modifies TE-3.7 to make sure default NI name is configured when configuring protocols.

@kjahed kjahed requested review from a team as code owners January 29, 2024 16:12
@kjahed kjahed requested review from a team and michaelore January 29, 2024 16:12
@OpenConfigBot
Copy link

Pull Request Functional Test Report for #2590 / 13df5a4

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
TE-3.7: Base Hierarchical NHG Update
Cisco 8000E status
TE-3.7: Base Hierarchical NHG Update
Cisco XRd status
TE-3.7: Base Hierarchical NHG Update
Juniper cPTX status
TE-3.7: Base Hierarchical NHG Update
Juniper ncPTX status
TE-3.7: Base Hierarchical NHG Update
Nokia SR Linux status
TE-3.7: Base Hierarchical NHG Update
Openconfig Lemming status
TE-3.7: Base Hierarchical NHG Update

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
TE-3.7: Base Hierarchical NHG Update
Cisco 8808 status
TE-3.7: Base Hierarchical NHG Update
Juniper PTX10008 status
TE-3.7: Base Hierarchical NHG Update
Nokia 7250 IXR-10e status
TE-3.7: Base Hierarchical NHG Update

Help

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7699055027

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.141%

Totals Coverage Status
Change from base Build 7691436259: 0.0%
Covered Lines: 1668
Relevant Lines: 3199

💛 - Coveralls

@nraghavendran nraghavendran merged commit 582a51f into openconfig:main Feb 8, 2024
11 checks passed
bkreddy143 pushed a commit to nokia/featureprofiles that referenced this pull request Feb 8, 2024
nsadhasivam pushed a commit that referenced this pull request Feb 9, 2024
* Adding Deviation to skip test with PBF action as decap/encap vrf

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* make sure ni name is configured (#2590)

* Fix introspection target in binding (#2642)

* fix introspection target

* remove name argument from makeDialer

* simplify binding_test a bit

* corrected typo

---------

Co-authored-by: Sergey Fomin <sergey.fomin@nokia.com>
Co-authored-by: Karim Jahed <kjahed@users.noreply.github.com>
Co-authored-by: Greg Dennis <5436032+greg-dennis@users.noreply.github.com>
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Feb 9, 2024
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Feb 9, 2024
…nconfig#2643)

* Adding Deviation to skip test with PBF action as decap/encap vrf

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* make sure ni name is configured (openconfig#2590)

* Fix introspection target in binding (openconfig#2642)

* fix introspection target

* remove name argument from makeDialer

* simplify binding_test a bit

* corrected typo

---------

Co-authored-by: Sergey Fomin <sergey.fomin@nokia.com>
Co-authored-by: Karim Jahed <kjahed@users.noreply.github.com>
Co-authored-by: Greg Dennis <5436032+greg-dennis@users.noreply.github.com>
bkreddy143 pushed a commit to nokia/featureprofiles that referenced this pull request Jul 17, 2024
bkreddy143 added a commit to nokia/featureprofiles that referenced this pull request Jul 17, 2024
…nconfig#2643)

* Adding Deviation to skip test with PBF action as decap/encap vrf

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* make sure ni name is configured (openconfig#2590)

* Fix introspection target in binding (openconfig#2642)

* fix introspection target

* remove name argument from makeDialer

* simplify binding_test a bit

* corrected typo

---------

Co-authored-by: Sergey Fomin <sergey.fomin@nokia.com>
Co-authored-by: Karim Jahed <kjahed@users.noreply.github.com>
Co-authored-by: Greg Dennis <5436032+greg-dennis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants