Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Deviation to skip test with PBF action as decap/encap vrf #2643

Merged
merged 6 commits into from
Feb 9, 2024

Conversation

bkreddy143
Copy link
Contributor

adding deviation to skip newly added sub tests for TE base on PBF action but currently not supported and same is tracked by b/323251581.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@bkreddy143 bkreddy143 requested review from a team as code owners February 8, 2024 06:22
@bkreddy143 bkreddy143 requested review from a team and michaelore February 8, 2024 06:22
@OpenConfigBot
Copy link

OpenConfigBot commented Feb 8, 2024

Pull Request Functional Test Report for #2643 / cb617ac

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.2: Backup NHG: Multiple NH
TE-3.7: Base Hierarchical NHG Update
TE-3.1: Base Hierarchical Route Installation
Cisco 8000E status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.2: Backup NHG: Multiple NH
TE-3.7: Base Hierarchical NHG Update
TE-3.1: Base Hierarchical Route Installation
Cisco XRd status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.2: Backup NHG: Multiple NH
TE-3.7: Base Hierarchical NHG Update
TE-3.1: Base Hierarchical Route Installation
Juniper cPTX status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.2: Backup NHG: Multiple NH
TE-3.7: Base Hierarchical NHG Update
TE-3.1: Base Hierarchical Route Installation
Juniper ncPTX status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.2: Backup NHG: Multiple NH
TE-3.7: Base Hierarchical NHG Update
TE-3.1: Base Hierarchical Route Installation
Nokia SR Linux status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.2: Backup NHG: Multiple NH
TE-3.7: Base Hierarchical NHG Update
TE-3.1: Base Hierarchical Route Installation
Openconfig Lemming status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.2: Backup NHG: Multiple NH
TE-3.7: Base Hierarchical NHG Update
TE-3.1: Base Hierarchical Route Installation

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.2: Backup NHG: Multiple NH
TE-3.7: Base Hierarchical NHG Update
TE-3.1: Base Hierarchical Route Installation
Cisco 8808 status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.2: Backup NHG: Multiple NH
TE-3.7: Base Hierarchical NHG Update
TE-3.1: Base Hierarchical Route Installation
Juniper PTX10008 status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.2: Backup NHG: Multiple NH
TE-3.7: Base Hierarchical NHG Update
TE-3.1: Base Hierarchical Route Installation
Nokia 7250 IXR-10e status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.2: Backup NHG: Multiple NH
TE-3.7: Base Hierarchical NHG Update
TE-3.1: Base Hierarchical Route Installation

Help

@coveralls
Copy link

coveralls commented Feb 8, 2024

Pull Request Test Coverage Report for Build 7837053163

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.298%

Totals Coverage Status
Change from base Build 7835975596: 0.0%
Covered Lines: 1673
Relevant Lines: 3199

💛 - Coveralls

Copy link
Contributor

@nsadhasivam nsadhasivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nsadhasivam nsadhasivam merged commit 2df50cb into openconfig:main Feb 9, 2024
11 checks passed
@LimeHat LimeHat deleted the PBFDeviation branch February 9, 2024 15:01
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Feb 9, 2024
…nconfig#2643)

* Adding Deviation to skip test with PBF action as decap/encap vrf

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* make sure ni name is configured (openconfig#2590)

* Fix introspection target in binding (openconfig#2642)

* fix introspection target

* remove name argument from makeDialer

* simplify binding_test a bit

* corrected typo

---------

Co-authored-by: Sergey Fomin <sergey.fomin@nokia.com>
Co-authored-by: Karim Jahed <kjahed@users.noreply.github.com>
Co-authored-by: Greg Dennis <5436032+greg-dennis@users.noreply.github.com>
bkreddy143 added a commit to nokia/featureprofiles that referenced this pull request Jul 17, 2024
…nconfig#2643)

* Adding Deviation to skip test with PBF action as decap/encap vrf

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* make sure ni name is configured (openconfig#2590)

* Fix introspection target in binding (openconfig#2642)

* fix introspection target

* remove name argument from makeDialer

* simplify binding_test a bit

* corrected typo

---------

Co-authored-by: Sergey Fomin <sergey.fomin@nokia.com>
Co-authored-by: Karim Jahed <kjahed@users.noreply.github.com>
Co-authored-by: Greg Dennis <5436032+greg-dennis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants