Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability tests failed in branch master for commit 7b6c4b690d0f4e33f96e9306466538bb7e600b01 #525

Closed
owais opened this issue Jul 24, 2020 · 0 comments

Comments

@owais
Copy link
Contributor

owais commented Jul 24, 2020

Link to failed job: https://circleci.com/gh/open-telemetry/opentelemetry-collector-contrib/9947.

@jrcamp jrcamp closed this as completed Jul 24, 2020
dyladan referenced this issue in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
Previously file exporter could write to existing file without truncating it.
Truncating is the desired behavior so that the file contains the new data only.
ljmsc referenced this issue in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
* Propagate context changes in mix tests

We will need this for testing the correlation context and baggage
items propagation between the APIs.

* Add baggage interoperation tests

The test adds a baggage item to active OT span and some correlation
key value to current Otel span. Then makes sure that the OT span
contains both the baggage item and some translated version of the
correlation key value its Otel sibling got, and that the Otel span
contains both the correlation key value and the baggage item its OT
sibling got.

* Add hooks functionality to baggage propagation

This introduces two kinds of hooks into the correlation context
code.

The set hook gets called every time we set a Map in the context. The
hook receives a context with the Map and returns a new context.

The get hook gets called every time we get a Map from the context. The
hook receives the context and the map, and returns a new Map.

These hooks will be used for correlation context and baggage items
propagation between the Otel and OT APIs.

* Warn on foreign opentracing span

* fixup for using otel propagators

* Add utility function for setting up bridge and context

This prepares the context by installing the hooks, so the correlation
context and baggage items can be propagated between the APIs.

* Add bridge span constructor

So I do not need to remember about initializing a newly added member
in several places now.

* Propagate baggage across otel and OT APIs

This uses the set hook functionality to propagate correlation context
changes from Otel to OT spans by inserting keys and values into the
baggage items. The get hook functionality is used to propagate baggage
items from active OT span into the otel correlation context.

* Use correlation Map for baggage items

We will put this map into the context with correlation context
functions, and that is easier if we have correlation.Map, not
map[string]string.

* Use otel propagators in bridge

The otel propagators are now kinda sorta usable for opentracing
bridge. Some more work is needed to make it fully work, though -
correlation context set with the otel API is not propagated to OT
spans as baggage items yet.

Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
codeboten pushed a commit that referenced this issue Nov 23, 2022
codeboten pushed a commit that referenced this issue Nov 24, 2023
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/pkg/sftp](https://togithub.com/pkg/sftp) | require | patch
| `v1.13.5` -> `v1.13.6` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>pkg/sftp (github.com/pkg/sftp)</summary>

### [`v1.13.6`](https://togithub.com/pkg/sftp/releases/tag/v1.13.6)

[Compare
Source](https://togithub.com/pkg/sftp/compare/v1.13.5...v1.13.6)

\[[GH-499](https://togithub.com/pkg/sftp/issues/499)] writeToSequential:
improve tests for write errors
\[[GH-513](https://togithub.com/pkg/sftp/issues/513)] More context for
EOF during client setup
\[[GH-516](https://togithub.com/pkg/sftp/issues/516)]
RealPathFileLister: allow to return an error
\[[GH-525](https://togithub.com/pkg/sftp/issues/525)] Document the
weirdness of the reversal of arguments to SSH_FXP_SYMLINK
\[[GH-526](https://togithub.com/pkg/sftp/issues/526)] request server:
handle relative symlinks
\[[GH-528](https://togithub.com/pkg/sftp/issues/528)] Add support for
working directory in Server
\[[GH-533](https://togithub.com/pkg/sftp/issues/533)] CI: add CIFuzz
integration
\[[GH-537](https://togithub.com/pkg/sftp/issues/537)] Stop
ReadFromWithConcurrency sending more data than it needs to
\[[GH-545](https://togithub.com/pkg/sftp/issues/545)] refactor sshfx
encoding, fix link rot, go fmt
\[[GH-553](https://togithub.com/pkg/sftp/issues/553)] Marshal extended
attribute data if FileInfo supports it
\[[GH-554](https://togithub.com/pkg/sftp/issues/554)] Properly handle
io.EOF error conditions when reading

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this issue Nov 24, 2023
…ry#29477)

[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/pkg/sftp](https://togithub.com/pkg/sftp) | require | patch
| `v1.13.5` -> `v1.13.6` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>pkg/sftp (github.com/pkg/sftp)</summary>

### [`v1.13.6`](https://togithub.com/pkg/sftp/releases/tag/v1.13.6)

[Compare
Source](https://togithub.com/pkg/sftp/compare/v1.13.5...v1.13.6)

\[[open-telemetryGH-499](https://togithub.com/pkg/sftp/issues/499)] writeToSequential:
improve tests for write errors
\[[open-telemetryGH-513](https://togithub.com/pkg/sftp/issues/513)] More context for
EOF during client setup
\[[open-telemetryGH-516](https://togithub.com/pkg/sftp/issues/516)]
RealPathFileLister: allow to return an error
\[[open-telemetryGH-525](https://togithub.com/pkg/sftp/issues/525)] Document the
weirdness of the reversal of arguments to SSH_FXP_SYMLINK
\[[open-telemetryGH-526](https://togithub.com/pkg/sftp/issues/526)] request server:
handle relative symlinks
\[[open-telemetryGH-528](https://togithub.com/pkg/sftp/issues/528)] Add support for
working directory in Server
\[[open-telemetryGH-533](https://togithub.com/pkg/sftp/issues/533)] CI: add CIFuzz
integration
\[[open-telemetryGH-537](https://togithub.com/pkg/sftp/issues/537)] Stop
ReadFromWithConcurrency sending more data than it needs to
\[[open-telemetryGH-545](https://togithub.com/pkg/sftp/issues/545)] refactor sshfx
encoding, fix link rot, go fmt
\[[open-telemetryGH-553](https://togithub.com/pkg/sftp/issues/553)] Marshal extended
attribute data if FileInfo supports it
\[[open-telemetryGH-554](https://togithub.com/pkg/sftp/issues/554)] Properly handle
io.EOF error conditions when reading

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants