-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stability tests failed in branch master for commit 7b6c4b690d0f4e33f96e9306466538bb7e600b01 #528
Comments
dyladan
referenced
this issue
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Change "batches_dropped" to a .Sum(), and emit 0s for them on processor start. Motivation: Currently with batches_dropped being a .Count() we end up with a missing metric for bad_batches until one occurs. This makes discovering the "error" metrics I want to watch kind of annoying as I can't just look in the default prom metric list and choose what I want to dashboard / alert on. I also think that for things we KNOW are 0, we should be emitting a 0. If we send 8000 batches, the bad_batches shouldn't be absent it should be 0. I do think that view.Count()'s should be initialized to 0 as well ( but I may not know the whole story there. ) I can add these to the other processors if we think this is a good idea. For now I just hoped the metric name is correct in my current production dashboards. Testing: I added some happy path metric tests to the processor. I can figure out a way to add bad path tests, it will just require a bunch of plumbing I think. Documentation: I think the metrics as a whole need better documentation, for example I "fail_sends" in the exporter wasn't actually an error. Maybe a distinction between data loss events or not?
ljmsc
referenced
this issue
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* add resource type. * sort attributes in test to fix ci. * add resource keys and update test.
codeboten
pushed a commit
that referenced
this issue
Nov 23, 2022
End to end verification for span creation using psycopg2 and dbapi integrations
codeboten
pushed a commit
that referenced
this issue
Nov 23, 2022
codeboten
pushed a commit
that referenced
this issue
Nov 24, 2023
[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/pkg/sftp](https://togithub.com/pkg/sftp) | require | patch | `v1.13.5` -> `v1.13.6` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pkg/sftp (github.com/pkg/sftp)</summary> ### [`v1.13.6`](https://togithub.com/pkg/sftp/releases/tag/v1.13.6) [Compare Source](https://togithub.com/pkg/sftp/compare/v1.13.5...v1.13.6) \[[GH-499](https://togithub.com/pkg/sftp/issues/499)] writeToSequential: improve tests for write errors \[[GH-513](https://togithub.com/pkg/sftp/issues/513)] More context for EOF during client setup \[[GH-516](https://togithub.com/pkg/sftp/issues/516)] RealPathFileLister: allow to return an error \[[GH-525](https://togithub.com/pkg/sftp/issues/525)] Document the weirdness of the reversal of arguments to SSH_FXP_SYMLINK \[[GH-526](https://togithub.com/pkg/sftp/issues/526)] request server: handle relative symlinks \[[GH-528](https://togithub.com/pkg/sftp/issues/528)] Add support for working directory in Server \[[GH-533](https://togithub.com/pkg/sftp/issues/533)] CI: add CIFuzz integration \[[GH-537](https://togithub.com/pkg/sftp/issues/537)] Stop ReadFromWithConcurrency sending more data than it needs to \[[GH-545](https://togithub.com/pkg/sftp/issues/545)] refactor sshfx encoding, fix link rot, go fmt \[[GH-553](https://togithub.com/pkg/sftp/issues/553)] Marshal extended attribute data if FileInfo supports it \[[GH-554](https://togithub.com/pkg/sftp/issues/554)] Properly handle io.EOF error conditions when reading </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this issue
Nov 24, 2023
…ry#29477) [![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/pkg/sftp](https://togithub.com/pkg/sftp) | require | patch | `v1.13.5` -> `v1.13.6` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pkg/sftp (github.com/pkg/sftp)</summary> ### [`v1.13.6`](https://togithub.com/pkg/sftp/releases/tag/v1.13.6) [Compare Source](https://togithub.com/pkg/sftp/compare/v1.13.5...v1.13.6) \[[open-telemetryGH-499](https://togithub.com/pkg/sftp/issues/499)] writeToSequential: improve tests for write errors \[[open-telemetryGH-513](https://togithub.com/pkg/sftp/issues/513)] More context for EOF during client setup \[[open-telemetryGH-516](https://togithub.com/pkg/sftp/issues/516)] RealPathFileLister: allow to return an error \[[open-telemetryGH-525](https://togithub.com/pkg/sftp/issues/525)] Document the weirdness of the reversal of arguments to SSH_FXP_SYMLINK \[[open-telemetryGH-526](https://togithub.com/pkg/sftp/issues/526)] request server: handle relative symlinks \[[open-telemetryGH-528](https://togithub.com/pkg/sftp/issues/528)] Add support for working directory in Server \[[open-telemetryGH-533](https://togithub.com/pkg/sftp/issues/533)] CI: add CIFuzz integration \[[open-telemetryGH-537](https://togithub.com/pkg/sftp/issues/537)] Stop ReadFromWithConcurrency sending more data than it needs to \[[open-telemetryGH-545](https://togithub.com/pkg/sftp/issues/545)] refactor sshfx encoding, fix link rot, go fmt \[[open-telemetryGH-553](https://togithub.com/pkg/sftp/issues/553)] Marshal extended attribute data if FileInfo supports it \[[open-telemetryGH-554](https://togithub.com/pkg/sftp/issues/554)] Properly handle io.EOF error conditions when reading </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Link to failed job: https://circleci.com/gh/open-telemetry/opentelemetry-collector-contrib/9947.
The text was updated successfully, but these errors were encountered: