Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies between modules #524

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

bogdandrutu
Copy link
Member

The main problem was that kubeletstatsreceiver did not replace the redisreceiver dependency with the local directory.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team July 24, 2020 18:41
@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #524 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
- Coverage   86.01%   85.96%   -0.05%     
==========================================
  Files         187      187              
  Lines       10063    10063              
==========================================
- Hits         8656     8651       -5     
- Misses       1089     1091       +2     
- Partials      318      321       +3     
Flag Coverage Δ
#integration 71.09% <ø> (ø)
#unit 85.79% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/signalfxexporter/dimensions/requests.go 84.48% <0.00%> (-8.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2820d97...e71d8ff. Read the comment docs.

@dmitryax
Copy link
Member

Thanks for finding this out!

@bogdandrutu
Copy link
Member Author

I spent 30 mins trying to understand this issue :(

@bogdandrutu bogdandrutu merged commit 9764b90 into open-telemetry:master Jul 24, 2020
@bogdandrutu bogdandrutu deleted the fixdeps branch February 1, 2021 20:42
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
* Add status message parameter

* Cleanups around use of codes.OK

* Update for status message
codeboten pushed a commit that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants