Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bumping golangci-lint to 1.50.0 to work with go 1.19 #208

Merged
merged 2 commits into from
Oct 12, 2022
Merged

bumping golangci-lint to 1.50.0 to work with go 1.19 #208

merged 2 commits into from
Oct 12, 2022

Conversation

SeanCondon
Copy link
Contributor

No description provided.

@SeanCondon SeanCondon self-assigned this Oct 12, 2022
@SeanCondon SeanCondon mentioned this pull request Oct 12, 2022
Merged
@adibrastegarnia
Copy link
Contributor

@SeanCondon
This new linter complains about Package comment. I guess we should change linter config to avoid this check for this repo and also other repos otherwise we should add Package comments which is too much.

@SeanCondon SeanCondon merged commit b5e6b21 into onosproject:master Oct 12, 2022
@SeanCondon SeanCondon deleted the scBumpGoLangLint branch October 12, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adibrastegarnia adibrastegarnia adibrastegarnia approved these changes

@tomikazi tomikazi Awaiting requested review from tomikazi

@ray-milkey ray-milkey Awaiting requested review from ray-milkey

@amolonf amolonf Awaiting requested review from amolonf

Assignees

@SeanCondon SeanCondon

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeanCondon @adibrastegarnia