Update Stable Cadence feature branch #5429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to gregor/evm/selfdestruct-test
set nonce for direct calls
…o-COA-proof-verification [Flow EVM] improvements to COA proof verification
…come-of-execution [Flow EVM] Reporting results for evm.Run and evm.coa.Call
[Flow EVM] Updating chain IDs
ramtinms
commented
Feb 21, 2024
Comment on lines
384
to
+391
| let coaRef = acc.capabilities.borrow<&EVM.CadenceOwnedAccount>(path) | ||
| ?? panic("could not borrow Cadence-owned account's address") | ||
|
|
||
| if coaRef == nil { | ||
| return ValidationResult( | ||
| isValid: false, | ||
| problem: "could not borrow bridge account's resource" | ||
| ) | ||
| } |
There was a problem hiding this comment.
Conflict resolution
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5429 +/- ##
==========================================================
+ Coverage 56.31% 57.83% +1.52%
==========================================================
Files 1023 852 -171
Lines 99140 84513 -14627
==========================================================
- Hits 55827 48875 -6952
+ Misses 39089 31894 -7195
+ Partials 4224 3744 -480
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
turbolent
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the stable cadence branch with the latest changes of the master. Only one conflict resolution (flagged in the comments)