-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flow EVM] Reporting results for evm.Run and evm.coa.Call #5397
[Flow EVM] Reporting results for evm.Run and evm.coa.Call #5397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see this included, thank you! The Cadence implementation looks good to me. I'm less familiar with the workings of the go implementation so will leave it for others to approve since that's the bulk of the code
gasLimit: gasLimit, | ||
value: value.attoflow | ||
) | ||
): Result { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@ramtinms I can help with the changes suggested above, please ping me if needed |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5397 +/- ##
==========================================
+ Coverage 56.03% 57.48% +1.44%
==========================================
Files 1024 853 -171
Lines 99258 84565 -14693
==========================================
- Hits 55623 48613 -7010
+ Misses 39392 32192 -7200
+ Partials 4243 3760 -483
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
closes: #5268