Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] Reporting results for evm.Run and evm.coa.Call #5397

Merged
merged 21 commits into from
Feb 21, 2024

Conversation

ramtinms
Copy link
Contributor

@ramtinms ramtinms commented Feb 15, 2024

closes: #5268

@ramtinms ramtinms changed the title Add control over outcome for evm.Run and evm.COA.Call Report results for evm.Run and evm.coa.Call Feb 15, 2024
@ramtinms ramtinms changed the title Report results for evm.Run and evm.coa.Call [Flow EVM] Report results for evm.Run and evm.coa.Call Feb 15, 2024
@ramtinms ramtinms changed the title [Flow EVM] Report results for evm.Run and evm.coa.Call [Flow EVM] Reporting results for evm.Run and evm.coa.Call Feb 15, 2024
@ramtinms ramtinms marked this pull request as ready for review February 15, 2024 20:32
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this included, thank you! The Cadence implementation looks good to me. I'm less familiar with the workings of the go implementation so will leave it for others to approve since that's the bulk of the code

gasLimit: gasLimit,
value: value.attoflow
)
): Result {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

fvm/evm/stdlib/contract.cdc Outdated Show resolved Hide resolved
fvm/evm/stdlib/contract.cdc Show resolved Hide resolved
fvm/evm/stdlib/contract.cdc Outdated Show resolved Hide resolved
fvm/evm/stdlib/contract.go Show resolved Hide resolved
@turbolent
Copy link
Member

@ramtinms I can help with the changes suggested above, please ping me if needed

Base automatically changed from ramtin/5225-returning-error to master February 16, 2024 23:02
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2024

Codecov Report

Attention: 144 lines in your changes are missing coverage. Please review.

Comparison is base (aa7161b) 56.03% compared to head (f6e3e16) 57.48%.

Files Patch % Lines
fvm/evm/types/codeFinder.go 0.00% 84 Missing ⚠️
fvm/evm/stdlib/contract.go 45.71% 38 Missing ⚠️
fvm/evm/types/result.go 0.00% 20 Missing ⚠️
fvm/evm/handler/handler.go 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5397      +/-   ##
==========================================
+ Coverage   56.03%   57.48%   +1.44%     
==========================================
  Files        1024      853     -171     
  Lines       99258    84565   -14693     
==========================================
- Hits        55623    48613    -7010     
+ Misses      39392    32192    -7200     
+ Partials     4243     3760     -483     
Flag Coverage Δ
unittests 57.48% <22.58%> (+1.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ramtinms ramtinms enabled auto-merge February 21, 2024 20:12
@ramtinms ramtinms added this pull request to the merge queue Feb 21, 2024
Merged via the queue into master with commit 84e22a4 Feb 21, 2024
49 of 51 checks passed
@ramtinms ramtinms deleted the ramtin/5268-add-control-over-outcome-of-execution branch February 21, 2024 21:10
@turbolent turbolent mentioned this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flow EVM] implement tryRun endpoint
6 participants