Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type #5450

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Fix return type #5450

merged 1 commit into from
Feb 23, 2024

Conversation

turbolent
Copy link
Member

No description provided.

@turbolent turbolent requested review from ramtinms and a team February 23, 2024 18:11
@turbolent turbolent self-assigned this Feb 23, 2024
@janezpodhostnik
Copy link
Contributor

How did CI not catch this? 🤔

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.97%. Comparing base (8f4ecc4) to head (f4dd026).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5450      +/-   ##
==========================================
- Coverage   55.98%   55.97%   -0.01%     
==========================================
  Files        1026     1026              
  Lines       99902    99902              
==========================================
- Hits        55930    55925       -5     
- Misses      39677    39683       +6     
+ Partials     4295     4294       -1     
Flag Coverage Δ
unittests 55.97% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent
Copy link
Member Author

turbolent commented Feb 23, 2024

I don't understand it either. I saw your PR (#5409) failed due to it, but it turns out it was an issue on master.

#5397, which introduced EVM.Result, got merged two days ago.

@turbolent turbolent merged commit 85cc479 into master Feb 23, 2024
50 of 51 checks passed
@turbolent turbolent deleted the bastian/fix-load-types-evm-test branch February 23, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants