[Flow EVM] improvements to COA proof verification #5379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5379 +/- ##
==========================================
+ Coverage 56.01% 57.14% +1.12%
==========================================
Files 1024 782 -242
Lines 99244 78585 -20659
==========================================
- Hits 55594 44906 -10688
+ Misses 39407 30096 -9311
+ Partials 4243 3583 -660
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…n' of github.com:onflow/flow-go into ramtin/5197-part4-improvemetns-to-COA-proof-verification
turbolent
reviewed
Feb 20, 2024
Co-authored-by: Bastian Müller <bastian@turbolent.com>
janezpodhostnik
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the COA proof verification function by returning a boolean from the invoke call, and handles errors properly (panic on fatal or backend errors)