Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed name overflow in user card #11094

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Spandan-Mishra
Copy link

@Spandan-Mishra Spandan-Mishra commented Mar 6, 2025

Proposed Changes

image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA in Mobile Devices
  • Completion of QA in Desktop Devices

Summary by CodeRabbit

  • New Features
    • The user’s name now displays a full name tooltip on hover, enhancing user interaction.
  • Style
    • Improved text handling to ensure names fit well within designated space without truncation issues.

@Spandan-Mishra Spandan-Mishra requested a review from a team as a code owner March 6, 2025 21:08
Copy link
Contributor

coderabbitai bot commented Mar 6, 2025

Walkthrough

The pull request updates the OrganizationUsers component by integrating a tooltip feature for displaying user names. This includes replacing the <h1> element with a tooltip structure that shows the full name on hover. Additionally, CSS classes have been modified to manage text overflow, and the conditional rendering for displaying a message when no users are found has been removed. No changes were made to exported or public entities.

Changes

File(s) Change Summary
src/pages/…/OrganizationUsers.tsx Introduced tooltip feature for user names: replaced <h1> with TooltipTrigger for full name display on hover; updated CSS classes to manage text overflow; removed conditional rendering for empty user states.

Possibly related PRs

Suggested labels

tested, reviewed

Suggested reviewers

  • Jacobjeevan
  • rithviknishad

Poem

Oh, hop and skip, a styling spree,
In tooltips bright, names dance with glee.
With overflow tamed and space just right,
My rabbit heart leaps in pure delight.
Code's a garden where changes bloom so bright! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0b22514 and b9a26d7.

📒 Files selected for processing (1)
  • src/pages/Organization/OrganizationUsers.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/pages/Organization/OrganizationUsers.tsx

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit b9a26d7
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67cb481b38888600072c7154
😎 Deploy Preview https://deploy-preview-11094.preview.ohc.network
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Spandan-Mishra
Copy link
Author

@Jacobjeevan have a look it this. fixed the issue

Copy link
Member

@yash-learner yash-learner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did not add the tool-tip as mentioned here #11012 (comment)

@Spandan-Mishra
Copy link
Author

Spandan-Mishra commented Mar 7, 2025

i added a title which displayed on hover, changing it to a tool tip on hover
@yash-learner @Jacobjeevan

@github-actions github-actions bot added needs-triage question Further information is requested labels Mar 7, 2025
Copy link
Contributor

@AdityaJ2305 AdityaJ2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Spandan-Mishra , Could you do same for other UserCard in codebase eg: FacilityUsers and DepartmentUsers

but First, let changes for this file get approved

Edit: #11151 u already created issue for this 😅 didn't notice

cc: @Jacobjeevan @yash-learner

@Spandan-Mishra
Copy link
Author

@AdityaJ2305 yeah sure. Once changes in this PR get approved, I will do it for other user cards 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required needs-triage question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Limit on user's name leads to overflow
4 participants