Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Limit on user's name leads to overflow #11012

Open
Spandan-Mishra opened this issue Mar 4, 2025 · 6 comments · May be fixed by #11094
Open

No Limit on user's name leads to overflow #11012

Spandan-Mishra opened this issue Mar 4, 2025 · 6 comments · May be fixed by #11094
Assignees
Labels
question Further information is requested

Comments

@Spandan-Mishra
Copy link

Spandan-Mishra commented Mar 4, 2025

Describe the bug
There is no limit on the length of the name which can be set for the user. This leads to overflow in the card component.

To Reproduce
Steps to reproduce the behavior:

Try to add a user and set a very long name for them.

Expected behavior
Some kind of limit can be set for the length of the name of the user. Just like how checks have been added for the password field, same can be done for the name.

Screenshots

Image

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Brave
  • Version 1.75.181

Additional context
I would like to work on this issue. Please provide the checks that you want me to implement (like password has check for length and contains lowercase, uppercase etc.). Change is required in the userFormSchema, so it would not take much time for me to complete it based on the instructions provided. I can do it within 1-2 days of being assigned.


🚨 DO NOT EDIT BELOW THIS LINE 🚨

Instructions for Requesting Assignment:

To request assignment, please clearly outline your solution and timeline by commenting on the issue using the format below:

Describe your solution clearly:
Provide a detailed explanation of your proposed solution, including your approach, key implementation steps, and relevant examples or references. Mention any dependencies, assumptions, or risks you foresee that might affect your timeline or implementation.

Expected Timeline:

  • End date: [Expected submission date of a completed Pull Request]

Additional Context:
Include any other relevant context, links, screenshots, or resources that support your proposed solution.

🚨 Your assignment may be unassigned if there is no activity or progress within the stated timeline unless communicated clearly and agreed upon.

@hrit2773
Copy link
Contributor

hrit2773 commented Mar 5, 2025

@Spandan-Mishra We have to validate it in the backend first and then frontend. Can I get it assigned. @Jacobjeevan

@Jacobjeevan
Copy link
Contributor

Jacobjeevan commented Mar 6, 2025

Let's not add any limits or validation for name length; propose another way to solve this.

Also follow the assignment instructions when requesting assignment.

@Spandan-Mishra
Copy link
Author

Approach:
Changes must be made in the OrganizationUsers.tsx component
There can be two solutions to this:

  1. Breaking the name to the next line, i.e, wrapping the long words
  2. Truncate the long names with ellipsis (...)

One more approach could be to truncate the name with ellipsis normally, and show the full name with wrapping on hover.

End Date: By end of tomorrow (07/03/25) or 1-2 Days after being assigned

@Jacobjeevan I would like to work on this issue, please assign it to me

@github-actions github-actions bot added needs-triage question Further information is requested labels Mar 6, 2025
@nihal467
Copy link
Member

nihal467 commented Mar 6, 2025

@Jacobjeevan can you comment on this

@Jacobjeevan
Copy link
Contributor

Jacobjeevan commented Mar 6, 2025

@Spandan-Mishra Truncate and tooltip 👍

Assigned

@Spandan-Mishra Spandan-Mishra linked a pull request Mar 6, 2025 that will close this issue
7 tasks
@Spandan-Mishra
Copy link
Author

Issue resolved @Jacobjeevan @nihal467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants