Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve responsiveness of User Details page #10714

Merged
merged 33 commits into from
Mar 4, 2025

Conversation

Tanuj1718
Copy link
Contributor

@Tanuj1718 Tanuj1718 commented Feb 20, 2025

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • New Features

    • Introduced tooltip functionality for user names and values, enhancing interactivity.
  • Style

    • Enhanced the visual layout of user information areas with improved alignment and consistent styling.
    • Adjusted text presentation to incorporate better overflow handling and truncation for a cleaner display of user details.
    • Updated semantic structure of HTML elements for better accessibility and styling consistency.

@Tanuj1718 Tanuj1718 requested a review from a team as a code owner February 20, 2025 09:16
Copy link
Contributor

coderabbitai bot commented Feb 20, 2025

Walkthrough

The pull request updates the HTML structure and styling of two user-related components. In the UserBanner component, class names are reordered, <h1> tags are replaced with <p> tags (with truncation handling), and the layout shifts from flex to grid. Additionally, the UserStatusIndicator receives an extra padding class. In UserViewDetails, <span> elements in the LabelValue component are replaced with <p> tags (with truncation applied to values). No changes were made to exported interfaces.

Changes

File(s) Change Summary
src/components/Users/UserBanner.tsx Reordered class names in the outer <div>; replaced <h1> with <p> for user names with the truncate class; updated layout from flex to grid grid-cols-1; added pl-0 to UserStatusIndicator; changed final <span> to <p>.
src/components/Users/UserViewDetails.tsx Replaced <span> elements with <p> in the LabelValue component (adding the truncate class to values); wrapped value display in TooltipComponent.

Possibly related PRs

Suggested labels

tested, reviewed

Suggested reviewers

  • Jacobjeevan
  • rithviknishad

Poem

I'm a coding bunny, full of glee,
Updating tags from <span> to <p> with ease,
With a hop in the grid and a skip in the flex,
Truncated texts now dance like little specks,
My paws type magic into every line—
CodeRabbit cheers these changes, so fine! 🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad537e2 and a254028.

📒 Files selected for processing (2)
  • src/components/Users/UserBanner.tsx (2 hunks)
  • src/components/Users/UserViewDetails.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/components/Users/UserViewDetails.tsx
  • src/components/Users/UserBanner.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit a854327
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67c697cb7cea9d0008439c5c
😎 Deploy Preview https://deploy-preview-10714.preview.ohc.network
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/components/Users/UserBanner.tsx (1)

28-32: Consider consolidating padding control.

The component has both addPadding prop and a className="pl-0" which might be redundant. Consider consolidating the padding control into a single approach.

                <UserStatusIndicator
                  user={userData}
-                  addPadding
-                  className="pl-0"
+                  className="pl-0 pr-2"  {/* Adjust padding in one place */}
                />
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d089c3 and de6422a.

📒 Files selected for processing (2)
  • src/components/Users/UserBanner.tsx (1 hunks)
  • src/components/Users/UserViewDetails.tsx (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/components/Users/UserViewDetails.tsx
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: cypress-run (1)
🔇 Additional comments (2)
src/components/Users/UserBanner.tsx (2)

15-15: LGTM! Container layout improvements look good.

The container layout changes maintain responsive behavior while ensuring proper width and consistent spacing.


22-22: LGTM! Grid layout enhances content structure.

The switch to grid layout with grid-cols-1 provides better control over content alignment and supports the responsive design goals.

Copy link
Contributor

@Jacobjeevan Jacobjeevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as draft, make the changes, test it fully, self-review and mark it as ready for review when done.

@Jacobjeevan Jacobjeevan marked this pull request as draft February 20, 2025 14:25
Copy link
Contributor

@Jacobjeevan Jacobjeevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also mark as ready for review.

Your PR is still in draft stage.

@Tanuj1718 Tanuj1718 marked this pull request as ready for review February 28, 2025 15:03
@nihal467
Copy link
Member

nihal467 commented Mar 4, 2025

LGTM

@khavinshankar khavinshankar merged commit 1973903 into ohcnetwork:develop Mar 4, 2025
17 checks passed
Copy link

github-actions bot commented Mar 4, 2025

@Tanuj1718 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facility Users Page needs responsiveness
4 participants