Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop __NEOFS__TICK things #279

Closed
roman-khimov opened this issue Dec 1, 2023 · 0 comments
Closed

Drop __NEOFS__TICK things #279

roman-khimov opened this issue Dec 1, 2023 · 0 comments
Labels
enhancement Improving existing functionality I2 Regular impact S3 Minimally significant U4 Nothing urgent

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when I see unused magic attributes.

Describe the solution you'd like

Drop __NEOFS_TICK from the specification. No one will ever use them, people never ever think of notifications in this way. We can try teaching them to do so, but likely what they want is for this to work without any additional per-object setups.

Can be deprecated as well if we care about v2.

Describe alternatives you've considered

Keep maintaining it forever.
@roman-khimov roman-khimov added the enhancement Improving existing functionality label Dec 1, 2023
@roman-khimov roman-khimov added U4 Nothing urgent S3 Minimally significant I2 Regular impact labels Dec 20, 2023
cthulhu-rider added a commit that referenced this issue Feb 22, 2024
@cthulhu-rider
Revert "[#195] object: Add notification well-known attributes"
74bd58b 
This reverts commit f67442d.

Notification attributes turned out to be unusable. Nobody uses them, so
they are purged.

Closes #279.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider cthulhu-rider mentioned this issue Feb 22, 2024
Closed
cthulhu-rider added a commit to nspcc-dev/neofs-sdk-go that referenced this issue Feb 26, 2024
@cthulhu-rider
object: Purge notification functionality
86f9df0 
It was removed from the protocol within
nspcc-dev/neofs-api#279.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-node that referenced this issue Feb 26, 2024
@cthulhu-rider
object: Purge notification functionality
982b2c9 
It was removed from the protocol within
nspcc-dev/neofs-api#279.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
This was referenced Feb 26, 2024
Merged
Merged
cthulhu-rider added a commit to nspcc-dev/neofs-node that referenced this issue Feb 26, 2024
@cthulhu-rider
object: Purge notification functionality
231c478 
It was removed from the protocol within
nspcc-dev/neofs-api#279.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-node that referenced this issue Feb 26, 2024
@cthulhu-rider
object: Stop supporting NETMAP_* X-headers
fe6d8fb 
They are not supported since
nspcc-dev/neofs-api#279. Now storage nodes
process the current epoch only.

Refs #1194.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Feb 26, 2024
@cthulhu-rider
Revert "[#195] object: Add notification well-known attributes"
5314f5c 
This reverts commit f67442d.

Notification attributes turned out to be unusable. Nobody uses them, so
they are purged.

Closes #279.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider cthulhu-rider mentioned this issue Feb 26, 2024
Merged
roman-khimov added a commit to nspcc-dev/neofs-sdk-go that referenced this issue Feb 27, 2024
@roman-khimov
object: Purge notification functionality (#557)
fa430c2 
* based on and blocked by
nspcc-dev/neofs-api#279
cthulhu-rider added a commit to nspcc-dev/neofs-node that referenced this issue Feb 28, 2024
@cthulhu-rider
object: Stop supporting object-level notifications
ecd2812 
They were marked as deprecated in the protocol in
nspcc-dev/neofs-api#279. NATS is no longer
needed.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-node that referenced this issue Feb 28, 2024
@cthulhu-rider
object: Stop supporting object-level notifications
a08075d 
They were marked as deprecated in the protocol in
nspcc-dev/neofs-api#279. NATS is no longer
needed.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-node that referenced this issue Feb 28, 2024
@cthulhu-rider
object: Stop supporting __NEOFS__NETMAP* X-headers
448ac71 
They are not supported since
nspcc-dev/neofs-api#279. Now storage nodes
process the current epoch only.

Refs #1194.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-node that referenced this issue Feb 28, 2024
@cthulhu-rider
object: Stop supporting object-level notifications
70a6c98 
They were marked as deprecated in the protocol in
nspcc-dev/neofs-api#279. NATS is no longer
needed.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-node that referenced this issue Feb 28, 2024
@cthulhu-rider
object: Stop supporting __NEOFS__NETMAP* X-headers
a4de38b 
They are not supported since
nspcc-dev/neofs-api#279. Now storage nodes
process the current epoch only.

Refs #1194.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-node that referenced this issue Feb 29, 2024
@cthulhu-rider
object: Stop supporting __NEOFS__NETMAP* X-headers
5ad331c 
They are not supported since
nspcc-dev/neofs-api#279. Now storage nodes
process the current epoch only.

Refs #1194.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality I2 Regular impact S3 Minimally significant U4 Nothing urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roman-khimov