Feat/Add notification object attributes #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realloc
suggested changes
Feb 15, 2022
object/types.proto
Outdated
| // * __NEOFS__TICK_TOPIC \ | ||
| // UTF-8 string topic ID that is used for object notification | ||
| // * __NEOFS__TICK_EPOCH \ | ||
| // Base10 encoded number that defines what epoch must produce |
| @@ -117,6 +117,12 @@ message Header { | |||
| // Marks smaller parts of a split bigger object | |||
| // * __NEOFS__EXPIRATION_EPOCH \ | |||
| // Tells GC to delete object after that epoch | |||
| // * __NEOFS__TICK_TOPIC \ | |||
There was a problem hiding this comment.
It' better to put it after TICK_EPOCH attribute, to simplify understanding.
object/types.proto
Outdated
| // * __NEOFS__TICK_EPOCH \ | ||
| // Base10 encoded number that defines what epoch must produce | ||
| // object notification (`0` value produces notification right | ||
| // after object put) |
There was a problem hiding this comment.
I'd also add a note that the notification body will contain object address in UFT-8 string.
There was a problem hiding this comment.
thought such details should be in spec, but added
There was a problem hiding this comment.
NeoFS Spec is automatically generated from this API definitions. =)
There was a problem hiding this comment.
i meant a few manually written words about notifications (that is why this PR does not close the issue)
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
cthulhu-rider
approved these changes
Feb 21, 2022
fyrchik
approved these changes
Feb 21, 2022
realloc
approved these changes
Feb 21, 2022
cthulhu-rider
added a commit
that referenced
this pull request
Feb 22, 2024
cthulhu-rider
added a commit
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #193.
I think it should not be included in the next (
2.11.0+) release, so it may wait.