object: Purge notification attributes #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74bd58b to
5314f5c
Compare
|
@roman-khimov deprecate means keep supporting, while lookin at #279 i thought we wanna stop supporting. CMIIW |
|
There is a difference of API-level and node-level for us. I want to drop this from node, obviously, but API-wise we can still remember these were used (and not add any additional meanings to them, for example). |
Notification attributes turned out to be unusable. Nobody uses them, so they are deprecated. Closes #279. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
5314f5c to
bc98431
Compare
|
got it, done |
roman-khimov
approved these changes
Feb 26, 2024
carpawell
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.