[v18.x] Backports for new release #224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #213 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #214 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #215 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #217 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Don't look for the last element but the third. PR-URL: #218 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Also, a couple of fixes in the updater. PR-URL: #219 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #220 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
A couple of fixes here: - Both the `uv_mutex_t` and `uv_cond_t` should be initialized before defining the lambda. - Add a boolean variable to make sure we're not waiting forever in the case the lambda code is run before reaching the `uv_cond_wait()`. PR-URL: #222 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
It should also cover the `start_profiling` fn execution. PR-URL: #222 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Increase the timeouts a bit to make sure the heapSampling and the cpuProfile are actually stopped before trying to start a new one. PR-URL: #222 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Commit picked from protocolbuffers/protobuf@6469795 PR-URL: #222 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #223 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
juanarbol
approved these changes
Nov 21, 2024
santigimeno
added a commit
that referenced
this pull request
Nov 21, 2024
A couple of fixes here: - Both the `uv_mutex_t` and `uv_cond_t` should be initialized before defining the lambda. - Add a boolean variable to make sure we're not waiting forever in the case the lambda code is run before reaching the `uv_cond_wait()`. PR-URL: #222 Reviewed-By: Trevor Norris <trev.norris@gmail.com> PR-URL: #224 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno
added a commit
that referenced
this pull request
Nov 21, 2024
Commit picked from protocolbuffers/protobuf@6469795 PR-URL: #222 Reviewed-By: Trevor Norris <trev.norris@gmail.com> PR-URL: #224 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
|
Landed in 4945b79...fea3481 |
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.