-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPU profile can produce invalid JSON with Regex function names #178
Comments
@robross0606 thanks for the report. I think we have a fix but couldn't reproduce the actual issue even by using your Regex. Could you provide a full reproducer? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When producing a CPU Profile where something like this is declared in the code:
The CPU profile is created, but not viewable in N|Solid console. It just hangs on this page forever:
Downloading and examining the profile as JSON, we can see the results are corrupted/invalid JSON because it does not properly escape Regex function names:
That should be this:
Neither N|Solid, nor Chrome Dev Tools nor VSCode, nor any other profile analysis tool can parse the file as generated by N|Solid.
The text was updated successfully, but these errors were encountered: