Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: escape funtionName in CPU Profiles #179

Closed
wants to merge 1 commit into from
Closed

deps: escape funtionName in CPU Profiles #179

wants to merge 1 commit into from

Conversation

santigimeno
Copy link
Member

Do not land yet. It needs a test before landing.

It should fix: #178

@santigimeno santigimeno self-assigned this Sep 9, 2024
@santigimeno santigimeno force-pushed the santi/fix_fn_escaping branch from e22c5e3 to c9ff8e8 Compare September 9, 2024 21:14
@santigimeno santigimeno force-pushed the santi/fix_fn_escaping branch from c9ff8e8 to 4f60eb9 Compare November 14, 2024 23:48
santigimeno added a commit that referenced this pull request Nov 21, 2024
@santigimeno
deps: escape funtionName in CPU Profiles
9a844ef 
PR-URL: #179
Fixes: #178
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@santigimeno
Copy link
Member Author

Landed in 9a844ef

@santigimeno santigimeno deleted the santi/fix_fn_escaping branch November 21, 2024 11:22
santigimeno added a commit that referenced this pull request Nov 21, 2024
@santigimeno
deps: escape funtionName in CPU Profiles
c55c35a 
PR-URL: #179
Fixes: #178
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
santigimeno added a commit that referenced this pull request Nov 21, 2024
@santigimeno
deps: escape funtionName in CPU Profiles
637af37 
PR-URL: #179
Fixes: #178
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
santigimeno added a commit that referenced this pull request Nov 21, 2024
@santigimeno
deps: escape funtionName in CPU Profiles
fea3481 
PR-URL: #179
Fixes: #178
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #224
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@juanarbol juanarbol mentioned this pull request Nov 22, 2024
Merged
santigimeno added a commit that referenced this pull request Nov 22, 2024
@santigimeno
deps: escape funtionName in CPU Profiles
d95c588 
PR-URL: #179
Fixes: #178
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #225
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevnorris trevnorris trevnorris approved these changes

Assignees

@santigimeno santigimeno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CPU profile can produce invalid JSON with Regex function names
2 participants
@santigimeno @trevnorris