init gateway api #328
init gateway api #328
Conversation
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
a677210 to
93b1cab
Compare
93b1cab to
e2f76dd
Compare
| log.V(1).Info("reconciliation triggered but gateway does not exist, ingnoring") | ||
| return ctrl.Result{Requeue: false}, nil | ||
| } | ||
| return ctrl.Result{Requeue: true}, nil |
There was a problem hiding this comment.
if the error != nil, but its not a not found error, requeueing makes sense, but should we log or send an event?
|
|
||
| log.V(1).Info("verifying gatewayclass") | ||
| gwClass := &gatewayv1.GatewayClass{} | ||
| if err := r.Client.Get(ctx, client.ObjectKey{Name: string(gw.Spec.GatewayClassName)}, gwClass); err != nil { |
There was a problem hiding this comment.
is a gateway class name required? just based on the ingress class, it was optional and you could register a default with the cluster. The way the ingress controller work FYI is the driver/store gathers all the ingress objects and then the driver calculation functions reference https://github.com/ngrok/kubernetes-ingress-controller/blob/main/internal/store/store.go#L319-L336 to get the filtered lists of ingress object that should be handled based on ingress class filtering. There are also other ways we could have handled this like filtering before inserting into the cache, but just a heads up about the pattern here incase you want to apply it
adb4efd to
a26ca96
Compare
5bcbad9 to
2aa8aaf
Compare
a26ca96 to
e09cba5
Compare
de9ea68 to
c3f901e
Compare
3d41cdf to
9e26c62
Compare
Co-authored-by: alex bezek <alex@ngrok.com>
9e26c62 to
8789113
Compare
What
Describe what the change is solving
How
Describe the solution
Breaking Changes
Are there any breaking changes in this PR?