migrate kubebuilder v3 to v4 #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
bcd7331 to
8cf081e
Compare
8cf081e to
94a53e6
Compare
alex-bezek
approved these changes
Jan 9, 2024
nikolay-ngrok
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Moves the ingress controller to ✨ kubebuilder v4 ✨. This way generation to
internal/controlleris handled automagically, andmain.gois in a more idiomatic location!original main.go move: https://github.com/ngrok/kubernetes-ingress-controller/pull/14
kubebuilder's package root move 📦 : kubernetes-sigs/kubebuilder#932
How
Followed the kubebuilder migration guide: https://book.kubebuilder.io/migration/manually_migration_guide_gov3_to_gov4
Breaking Changes
Nope!