Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to multigroup #327

Merged
merged 1 commit into from
Jan 11, 2024
Merged

migrate to multigroup #327

merged 1 commit into from
Jan 11, 2024

Conversation

Abdiramen
Copy link
Collaborator

@Abdiramen Abdiramen commented Dec 28, 2023

What

Migrate to multi-group configurations so that ingress and gateway will have directories specifically scoped to them.

How

Followed kubebuilder's migration guide for single to multi-group: https://book.kubebuilder.io/migration/multi-group

Breaking Changes

Nope!

@Abdiramen
Copy link
Collaborator Author

Abdiramen commented Dec 28, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added the area/controller Issues dealing with the controller label Dec 28, 2023
@Abdiramen Abdiramen force-pushed the oz/kubebuilder-multigroup branch 4 times, most recently from 9722c18 to adb4efd Compare December 28, 2023 01:53
@Abdiramen Abdiramen mentioned this pull request Dec 28, 2023
@CK-Ward CK-Ward marked this pull request as ready for review January 8, 2024 19:20
@CK-Ward CK-Ward requested a review from a team as a code owner January 8, 2024 19:20
Base automatically changed from oz/kubebuilder-v4 to main January 9, 2024 21:15
@alex-bezek
Copy link
Collaborator

Functionally, the grouping seems fine. Thanks for linking the kubebuilder docs about what the multi-group stuff is as I hadn't heard of it.

My only confusion about their docs vs what we have here is if its about k8s standard domains/groups vs custom domains/groups.

Their example, they are talking about the CronJob example which uses the group batch.tutorial.kubebuilder.io which would be custom. In this PR we moved all the API CRD types and all the controllerso to be grouped under the folder ingress. Our group is ingress.k8s.ngrok.com but maybe we just peal off the ingress part and are using that?

But for the controllers the ingress_controller is also under this now, and we are creating a gateway controller soon. These use the group networking.k8s.io

I don't really know how its supposed to be structured, just some of these seem a little confusing based on my understanding of groups and the docs linked. I'm curious if you have a better understanding of how these k8s standard groups vs custom crd groups play into this multi-group refactor.

That being said, if at the end of the day its just an organization thing and they can be moved easily, we don't need to bikeshed this forever and can move forward and iterate. Thanks for the change/upgrade!

@Abdiramen Abdiramen force-pushed the oz/kubebuilder-multigroup branch from adb4efd to a26ca96 Compare January 10, 2024 17:11
@Abdiramen Abdiramen force-pushed the oz/kubebuilder-multigroup branch from a26ca96 to e09cba5 Compare January 10, 2024 19:27
@Abdiramen Abdiramen merged commit 65ded8f into main Jan 11, 2024
16 checks passed
@Abdiramen Abdiramen deleted the oz/kubebuilder-multigroup branch January 11, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Issues dealing with the controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants