Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for assay, platform, template #179

Merged
merged 6 commits into from
Jul 15, 2022
Merged

Conversation

anngvu
Copy link
Collaborator

@anngvu anngvu commented Jul 13, 2022

NextSeq 2000,Illumina NextSeq 2000,,,FALSE,,platform,,,,NextSeq 2000,Class,Assay,Platform,Platform,,,
HiSeq2000,Illumina HiSeq 2000,,,FALSE,https://www.ncbi.nlm.nih.gov/geo/query/acc.cgi?acc=GPL11154,platform,,,,HiSeq2000,Class,Assay,Platform,Platform,,,
MiSeq,Illumina MiSeq,,,FALSE,https://www.ncbi.nlm.nih.gov/geo/query/acc.cgi?acc=GPL15520,platform,,,,MiSeq,Class,Assay,Platform,Platform,,,
Illumina HiSeq 3000,Illumina HiSeq 3000,,,FALSE,https://www.ncbi.nlm.nih.gov/geo/query/acc.cgi?acc=GPL21290,platform,,,,HiSeq3000,Class,Assay,Platform,Platform,,,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Do we need to remap values in the portal as well?

Copy link
Collaborator Author

@anngvu anngvu Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, can track that in the internal JIRA issue.

@allaway
Copy link
Contributor

allaway commented Jul 14, 2022

Re M3 MPNST: I think the name "M3 MPNST" is fine since that is the value as provided by the ctb on GEO. A description could be "A patient-derived MPNST cell line." We can also create a nf tools database listing, time permitting. Maybe once they publish their paper.

@anngvu anngvu marked this pull request as ready for review July 15, 2022 00:19
Copy link
Contributor

@allaway allaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants