Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata tidying/presentation: reform camelcased assay values #236

Closed
allaway opened this issue Jan 12, 2023 · 1 comment · Fixed by #267
Closed

Metadata tidying/presentation: reform camelcased assay values #236

allaway opened this issue Jan 12, 2023 · 1 comment · Fixed by #267
Assignees
@anngvu
Labels
migration

Comments

@allaway
Copy link
Contributor

allaway commented Jan 12, 2023

This is low priority, but I think it would add a lot of polish to the portal to deprecate the camelcase attributes. See, for example, here:

Screen Shot 2023-01-11 at 5 11 58 PM

The portal has logic to convert camelCased column names/annotation keys to Title Case, but this doesn't apply to annotation values.
@anngvu anngvu changed the title Metadata tidying/presentation: remove camelcased values Metadata tidying/presentation: reform camelcased assay values Mar 14, 2023
@anngvu
Copy link
Collaborator

anngvu commented Mar 14, 2023

Updated scope to assays to be more concise. Just for context, this is of the same type of work as reformation of platform values in PR #179.

@anngvu anngvu self-assigned this Mar 15, 2023
@anngvu anngvu moved this to In Progress in NF-OSI Sprints Mar 15, 2023
anngvu added a commit that referenced this issue Mar 15, 2023
@anngvu
Tidy assay labels per #236
ae0b1ea
@anngvu anngvu mentioned this issue Mar 16, 2023
Merged
@anngvu anngvu linked a pull request Mar 16, 2023 that will close this issue
Patch/assays #267
Merged
allaway added a commit that referenced this issue Mar 17, 2023
@anngvu @nfosi-service @allaway
Patch/assays (#267)
0323165 
* Reorg and start new mappings

* Tidy assay labels per #236

* Add new assay per #260

* Add assays per #258 and #259

* Add new assay terms for #261 #262 #263, allow generic mass spec term

* Update portal assay cleanup mappings

* Add assay referenced in #264

* Add behavioral assays per #265

* Update assay valid values

* Update mapping title and description

* Update superdataset registered schema

* Lint YAML file

* Clean description in mapping file

* Update mapping README and mapping file name-version

* Close issue #266

* Build jsonld

* Apply batch of de-acronym suggestions

Co-authored-by: Robert Allaway <allaway@users.noreply.github.com>

* Build jsonld

* Apply suggestions from code review

Co-authored-by: Robert Allaway <allaway@users.noreply.github.com>

* Fix missing quotes and correct internal class IDS

* Tweak label to be more consistent and update descriptions

* De-acronym LFP

* De-acronym LTP

* Update assay valid values

* Make mapping consistent with one correction

* Update registered schema again

* Build jsonld

---------

Co-authored-by: nf-osi[bot] <nf-osi@sagebionetworks.org>
Co-authored-by: Robert Allaway <allaway@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in NF-OSI Sprints Mar 17, 2023
@anngvu anngvu mentioned this issue Aug 16, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anngvu anngvu

Labels
migration
Projects
NF-OSI Sprints
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patch/assays nf-osi/nf-metadata-dictionary
2 participants
@allaway @anngvu