Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [focus forming assay] to [assay] #266

Closed
anngvu opened this issue Mar 16, 2023 · 0 comments · Fixed by #267
Closed

Add [focus forming assay] to [assay] #266

anngvu opened this issue Mar 16, 2023 · 0 comments · Fixed by #267
Assignees
@anngvu

Comments

@anngvu
Copy link
Collaborator

anngvu commented Mar 16, 2023

List the new value
Value: focus forming assay

Provide definition and source for the new value
Definition: The focus forming assay (FFA) is an immunostaining technique and a variation of the viral plaque assay. Instead of detecting the plaque formation after virus-induced cell lysis these assays detect infected host cells and infectious virus particles before a plaque is formed. (https://www.bpes.co.uk/focus-forming-assay-virus-titer-quantitation/)

Are there similar but not-quite-right values?
There doesn't appear to be an ontology term match, surprisingly.

Additional comments
Currently used in portal.
@anngvu anngvu added the schema label Mar 16, 2023
@anngvu anngvu self-assigned this Mar 16, 2023
@anngvu anngvu moved this to In Progress in NF-OSI Sprints Mar 16, 2023
anngvu added a commit that referenced this issue Mar 16, 2023
@anngvu
Close issue #266
5cd2549
@anngvu anngvu mentioned this issue Mar 16, 2023
Merged
@anngvu anngvu linked a pull request Mar 16, 2023 that will close this issue
Patch/assays #267
Merged
allaway added a commit that referenced this issue Mar 17, 2023
@anngvu @nfosi-service @allaway
Patch/assays (#267)
0323165 
* Reorg and start new mappings

* Tidy assay labels per #236

* Add new assay per #260

* Add assays per #258 and #259

* Add new assay terms for #261 #262 #263, allow generic mass spec term

* Update portal assay cleanup mappings

* Add assay referenced in #264

* Add behavioral assays per #265

* Update assay valid values

* Update mapping title and description

* Update superdataset registered schema

* Lint YAML file

* Clean description in mapping file

* Update mapping README and mapping file name-version

* Close issue #266

* Build jsonld

* Apply batch of de-acronym suggestions

Co-authored-by: Robert Allaway <allaway@users.noreply.github.com>

* Build jsonld

* Apply suggestions from code review

Co-authored-by: Robert Allaway <allaway@users.noreply.github.com>

* Fix missing quotes and correct internal class IDS

* Tweak label to be more consistent and update descriptions

* De-acronym LFP

* De-acronym LTP

* Update assay valid values

* Make mapping consistent with one correction

* Update registered schema again

* Build jsonld

---------

Co-authored-by: nf-osi[bot] <nf-osi@sagebionetworks.org>
Co-authored-by: Robert Allaway <allaway@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in NF-OSI Sprints Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anngvu anngvu

Labels
None yet
Projects
NF-OSI Sprints
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patch/assays nf-osi/nf-metadata-dictionary
1 participant
@anngvu