PHP8 CI #23780

rullzer · 2020-10-29T13:39:56Z

Good to go!

The test for other DBs will follow in later PRs

MorrisJobke · 2020-11-02T09:19:29Z

[ ] Rebase once #23764 is in

Please also wait for #23834

rullzer · 2020-12-02T20:39:02Z

There was 1 failure:

1) Test\LargeFileHelperGetFileSizeTest::testGetFileSizeViaExec with data set #1 ('/drone/src/tests/data/strängé...2).txt', 446)
Failed asserting that null is identical to 446.

/drone/src/tests/lib/LargeFileHelperGetFileSizeTest.php:70

I think this is a locale issue...
See also: https://3v4l.org/vHqno

There was 1 error:

1) Test\Mail\EMailTemplateTest::testEMailTemplateSingleButton
ValueError: Unknown format specifier ";"

/drone/src/lib/private/Mail/EMailTemplate.php:592
/drone/src/tests/lib/Mail/EMailTemplateTest.php:180

No clue about that one yet.

rullzer · 2020-12-03T19:45:33Z

Ok lets review and see if we can still get this in.

nickvergessen · 2020-12-03T19:53:47Z

apps/dav/tests/unit/BackgroundJob/UpdateCalendarResourcesRoomsBackgroundJobTest.php

@@ -108,9 +112,9 @@ public function testRun() {
 		$backend3 = $this->createMock(IBackend::class);
 		$backend4 = $this->createMock(IBackend::class);

-		$res6 = $this->createMock([IResource::class, IMetadataProvider::class]);


oh wait, that worked?

Yes... But killed in php unit 9

rullzer · 2020-12-04T07:31:20Z

The psalm errors come from the fact that it doesn't support php8 properly i guess. since it doesn't know that openssl returns an object now. And the GD stuff a GdImage.

rullzer · 2020-12-04T08:14:23Z

Sure now oracle is complaining...

nickvergessen · 2020-12-04T08:18:50Z

Seems like

server/lib/private/AppConfig.php

Lines 134 to 138 in db82d27

    
           public function getSortedKeys($data) { 
        
           	$keys = array_keys($data); 
        
           	sort($keys); 
        
           	return $keys; 
        
           }

doesn't sort numbers before characters anymore

ChristophWurst · 2020-12-04T08:24:57Z

The psalm errors come from the fact that it doesn't support php8 properly i guess. since it doesn't know that openssl returns an object now. And the GD stuff a GdImage.

could it be because of build/stubs?

rullzer · 2020-12-07T12:19:42Z

The psalm errors come from the fact that it doesn't support php8 properly i guess. since it doesn't know that openssl returns an object now. And the GD stuff a GdImage.

could it be because of build/stubs?

No clue why. But I chose to igrnoe it for now

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

the assertAttributeEquals got removed. So we can't run these tests anymore. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

The comparrison on php8 return true while <php8 it is false. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

* We should pick better default method! Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

faily-bot · 2020-12-07T15:31:25Z

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 273: failure

mariadb10.4-php7.4

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\ShareByMail\Tests\ShareByMailProviderTest::testAddShareToDB
Failed asserting that 0 is identical to 1.

/drone/src/apps/sharebymail/tests/ShareByMailProviderTest.php:556

ChristophWurst

I like the part where we skip tests -> faster CI 🚀

nickvergessen

🦈 Bite by Bite

guystreeter · 2021-10-26T22:02:24Z

The PHP 8 changes for lib/private/legacy/OC_Image.php are incomplete. There are several more places where is_resource is used on an object. The loadFrom* and *resize* functions and the crop function use it and need to be modified.

nickvergessen · 2021-10-26T23:56:03Z

You mean 8.1? See #29287 for details

guystreeter · 2021-10-27T03:05:02Z

If that was a response to my comment, these functions are broken in 8.0. I don't see anything in that indicating 8.1 will be any different.

nickvergessen · 2021-10-27T10:21:49Z

Ah sorry, then I mixed it up.
Anyway please create a new bug report. Replying to a 1year old PR which was merged is not going to be successful

rullzer added the 2. developing Work in progress label Oct 29, 2020

rullzer added this to the Nextcloud 21 milestone Oct 29, 2020

rullzer force-pushed the enh/ci/php8 branch from aaeb770 to c0df92b Compare October 31, 2020 07:56

rullzer force-pushed the enh/ci/php8 branch 2 times, most recently from 87b3f1c to 336d919 Compare November 10, 2020 19:07

rullzer mentioned this pull request Nov 10, 2020

ReflectionParamter::getClass is deprecated #24037

Merged

rullzer force-pushed the enh/ci/php8 branch 2 times, most recently from dbe36da to 69a2d89 Compare November 30, 2020 15:29

rullzer force-pushed the enh/ci/php8 branch from dac3310 to 4a08e0a Compare December 3, 2020 11:31

rullzer requested review from ChristophWurst, MorrisJobke, nickvergessen and juliusknorr December 3, 2020 19:45

nickvergessen reviewed Dec 3, 2020

View reviewed changes

rullzer force-pushed the enh/ci/php8 branch from c04df80 to 79695f8 Compare December 7, 2020 13:10

rullzer added 7 commits December 7, 2020 15:43

Add php8 CI

b611bc3

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Fix test traits for phpunit 9

9317e0f

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Avatar fixes

c084008

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Don't check on php8

988ce13

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Move to new phpunit

6b7731a

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Do not run on php8

1670eab

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Do not run image tests on php8

d690f90

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

rullzer added 15 commits December 7, 2020 15:44

Fix notifier test

7f0b273

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Fix MoveCalendarTest

673beef

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

FIX

b7dd207

the assertAttributeEquals got removed. So we can't run these tests anymore. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Fix locking logic

0e10d8c

The comparrison on php8 return true while <php8 it is false. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Fix encryption test

98eede7

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

We can no longe mock multiple interfaces

b98fbcb

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Make sure we can also run with escapedshell args

a25b46f

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Fix filesystem tests

b668850

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

FIXME use default RC4 method

b3037de

* We should pick better default method! Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

fix appconfig tests

c02e6fc

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Harde CapabiltiesTest

bbf66f8

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

GD images

7f61535

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Cancel 1 LDAP test for php8

54ef1a7

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

php cs fix

6a7e849

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Update psalm baseline

a9ee98e

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

rullzer force-pushed the enh/ci/php8 branch from eae6bf0 to a9ee98e Compare December 7, 2020 14:44

rullzer added 3. to review Waiting for reviews enhancement and removed 2. developing Work in progress labels Dec 7, 2020

ChristophWurst approved these changes Dec 7, 2020

View reviewed changes

nickvergessen approved these changes Dec 8, 2020

View reviewed changes

rullzer merged commit fda6ffc into master Dec 8, 2020

rullzer deleted the enh/ci/php8 branch December 8, 2020 08:39

matiasdelellis mentioned this pull request Sep 15, 2021

PHP 8 support of php extension matiasdelellis/facerecognition#456

Closed

ChristophWurst mentioned this pull request Oct 21, 2021

Support PHP8.1 #29287

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHP8 CI #23780

PHP8 CI #23780

rullzer commented Oct 29, 2020 •

edited

Loading

MorrisJobke commented Nov 2, 2020

rullzer commented Dec 2, 2020

rullzer commented Dec 3, 2020

nickvergessen Dec 3, 2020

rullzer Dec 3, 2020

rullzer commented Dec 4, 2020

rullzer commented Dec 4, 2020

nickvergessen commented Dec 4, 2020

ChristophWurst commented Dec 4, 2020

rullzer commented Dec 7, 2020

faily-bot bot commented Dec 7, 2020

ChristophWurst left a comment

nickvergessen left a comment

guystreeter commented Oct 26, 2021

nickvergessen commented Oct 26, 2021

guystreeter commented Oct 27, 2021

nickvergessen commented Oct 27, 2021

PHP8 CI #23780

PHP8 CI #23780

Conversation

rullzer commented Oct 29, 2020 • edited Loading

MorrisJobke commented Nov 2, 2020

rullzer commented Dec 2, 2020

rullzer commented Dec 3, 2020

nickvergessen Dec 3, 2020

Choose a reason for hiding this comment

rullzer Dec 3, 2020

Choose a reason for hiding this comment

rullzer commented Dec 4, 2020

rullzer commented Dec 4, 2020

nickvergessen commented Dec 4, 2020

ChristophWurst commented Dec 4, 2020

rullzer commented Dec 7, 2020

faily-bot bot commented Dec 7, 2020

Status of 273: failure

mariadb10.4-php7.4

ChristophWurst left a comment

Choose a reason for hiding this comment

nickvergessen left a comment

Choose a reason for hiding this comment

guystreeter commented Oct 26, 2021

nickvergessen commented Oct 26, 2021

guystreeter commented Oct 27, 2021

nickvergessen commented Oct 27, 2021

rullzer commented Oct 29, 2020 •

edited

Loading