[3rdparty] Bump doctrine/dbal to 2.12.0 #23764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d09d13a to
fe47c42
Compare
|
Needed for php8 stuff. |
Just update the baseline and we can move forward then. |
nickvergessen
approved these changes
Oct 29, 2020
Merged
Please update the baseline and then we can merge this :) |
0fc40be to
ae5e0ec
Compare
MorrisJobke
reviewed
Oct 29, 2020
ae5e0ec to
bed704b
Compare
MorrisJobke
reviewed
Oct 29, 2020
build/psalm-baseline.xml
Outdated
| @@ -3554,6 +3562,9 @@ | |||
| <InvalidScalarArgument occurrences="1"> | |||
| <code>$e->getCode()</code> | |||
| </InvalidScalarArgument> | |||
| <LessSpecificImplementedReturnType occurrences="2"> | |||
| <code>Doctrine\DBAL\Driver\Statement</code> | |||
There was a problem hiding this comment.
That changes from Doctrine\DBAL\Statement upstream to Doctrine\DBAL\Driver\Statement on our side and may be a bigger problem.
Needed for php8 support Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
executeUpdate is deprecated in favor of executeStatement. We overwrote the old one hence the prefix was no longer replaced. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
bed704b to
fe46149
Compare
|
Mmmm we still need a psalm baseline update. Lets do that separatly then. As to not delay this (as php8 stuff also depends on it). |
|
Psalm fix is in #23834 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for php8 support
Requires: