ReflectionParamter::getClass is deprecated

[rullzer]

In php8 this starts throwing warnings. And since we use it quite often
we flood the log. This moves it to getType which does the same. Only non
deprecated now.

For #23780

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35399: failure

mysql5.6-php7.3

Show full log

There was 1 error:

1) OCA\Files_Sharing\Tests\LockingTest::testUnLockAsRecipient
OCP\Files\StorageNotAvailableException: File with id "8431" has not been found.

/drone/src/lib/private/Files/Storage/FailedStorage.php:114
/drone/src/lib/private/Files/Storage/Wrapper/Jail.php:235
/drone/src/lib/private/Files/View.php:1167
/drone/src/lib/private/Files/View.php:543
/drone/src/lib/private/Files/Filesystem.php:701
/drone/src/apps/files_sharing/tests/LockingTest.php:75

Caused by
OCP\Files\NotFoundException: File with id "8431" has not been found.

/drone/src/lib/private/Files/View.php:1768
/drone/src/apps/files_sharing/lib/SharedStorage.php:130
/drone/src/apps/files_sharing/lib/SharedStorage.php:487
/drone/src/lib/private/Files/Storage/Wrapper/Jail.php:235
/drone/src/lib/private/Files/View.php:1167
/drone/src/lib/private/Files/View.php:543
/drone/src/lib/private/Files/Filesystem.php:701
/drone/src/apps/files_sharing/tests/LockingTest.php:75

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

[danxuliu]

This causes BackendNotifier unit tests in Talk to fail with:

OCP\AppFramework\QueryException: Could not resolve urlGenerator! Class urlGenerator does not exist

/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php:115
/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php:126
/var/www/html/lib/private/ServerContainer.php:162
/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php:96
/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php:101
/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php:109
/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php:126
/var/www/html/lib/private/ServerContainer.php:162
/var/www/html/tests/lib/TestCase.php:60
/var/www/html/apps/spreed/tests/php/Signaling/BackendNotifierTest.php:136

Does something need to be adjusted in Talk now? Or does it need to be fixed here?

[rullzer]

This causes BackendNotifier unit tests in Talk to fail with:

OCP\AppFramework\QueryException: Could not resolve urlGenerator! Class urlGenerator does not exist

/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php:115
/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php:126
/var/www/html/lib/private/ServerContainer.php:162
/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php:96
/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php:101
/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php:109
/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php:126
/var/www/html/lib/private/ServerContainer.php:162
/var/www/html/tests/lib/TestCase.php:60
/var/www/html/apps/spreed/tests/php/Signaling/BackendNotifierTest.php:136

Does something need to be adjusted in Talk now? Or does it need to be fixed here?

good question let me check