Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APM Log Forwarding #559

Merged
merged 15 commits into from
Jun 9, 2022
Merged

APM Log Forwarding #559

merged 15 commits into from
Jun 9, 2022

Conversation

TimPansino
Copy link
Contributor

Overview

This PR adds first class support for log events as a new data type collected by the agent. Included with this feature is instrumentation for standard lib logging, as well as the loguru package.

umaannamalai and others added 3 commits May 3, 2022 15:40
* Fix crash in route wrappers for Starlette 0.19.1 (#527)

* Fix crash in route wrappers for starlette 0.19.1

Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com>
Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com>

* [Mega-Linter] Apply linters fixes

* Bump Tests

Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com>
Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com>
Co-authored-by: TimPansino <TimPansino@users.noreply.github.com>

* Add logging configuration settings.

* [Mega-Linter] Apply linters fixes

* Trigger tests.

Co-authored-by: Timothy Pansino <11214426+TimPansino@users.noreply.github.com>
Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com>
Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com>
Co-authored-by: TimPansino <TimPansino@users.noreply.github.com>
* Update settings for logging (HSM, harvest config)

Uma Annamalai <umaannamalai@users.noreply.github.com>

* [Mega-Linter] Apply linters fixes

* Fix high security mode tests for application logging

* [Mega-Linter] Apply linters fixes

Co-authored-by: umaannamalai <umaannamalai@users.noreply.github.com>
Co-authored-by: Tim Pansino <timpansino@gmail.com>
Co-authored-by: TimPansino <TimPansino@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented May 27, 2022

MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
❌ PYTHON bandit 44 2 3.55s
✅ PYTHON black 44 35 0 10.25s
❌ PYTHON flake8 44 7 3.26s
✅ PYTHON isort 44 36 0 0.47s
❌ PYTHON pylint 44 324 24.03s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

TimPansino and others added 10 commits May 27, 2022 13:14
* Add harvesting for log events

* Fixing harvest tests

* Add suggestions from code review

* Fix intermittent validator failures
* Add record_log_event API

Co-authored-by: Lalleh Rafeei lrafeei@users.noreply.github.com
Co-authored-by: Uma Annamalai umaannamalai@users.noreply.github.com
Co-authored-by: Tim Pansino timpansino@users.noreply.github.com

* Fix issues with record log events tests

* Fix logs in context tests

* Fix python 2 syntax errors

Co-authored-by: Timothy Pansino <11214426+TimPansino@users.noreply.github.com>
Co-authored-by: Tim Pansino <timpansino@gmail.com>
* Add logging instrumentation

Uma Annamalai umaannamalai@users.noreply.github.com

* Address code review comments.

* Fix testing failures

Co-authored-by: Timothy Pansino <11214426+TimPansino@users.noreply.github.com>
Co-authored-by: Tim Pansino <timpansino@gmail.com>
* Add loguru instrumentation

* Add more loguru versions to test

* Correct tox ini file

* Fix missing parenthesis

* Fix loguru v4 and add patching test

* Patch loguru v3 support
* Add logging supportability metrics

Co-authored-by: Lalleh Rafeei lrafeei@users.noreply.github.com
Co-authored-by: Uma Annamalai umaannamalai@users.noreply.github.com
Co-authored-by: Tim Pansino timpansino@users.noreply.github.com

* Unit test adjustments

Co-authored-by: Tim Pansino <timpansino@gmail.com>
* Add log fowarding handler API.

* Fix pypy import
* Add application logging settings to newrelic.ini.

* Comment out logging settings.
* Clean out logging testing

* Add test for fixed loguru patcher forwarding

* Add catch test to loguru
@TimPansino TimPansino added this to the v7.12.0.176 milestone Jun 8, 2022
@TimPansino TimPansino marked this pull request as ready for review June 8, 2022 18:08
@TimPansino TimPansino requested a review from a team June 8, 2022 18:08
@TimPansino TimPansino merged commit ef43486 into main Jun 9, 2022
@TimPansino TimPansino deleted the develop-logging branch June 9, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants