-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APM Log Forwarding #559
Merged
Merged
APM Log Forwarding #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix crash in route wrappers for Starlette 0.19.1 (#527) * Fix crash in route wrappers for starlette 0.19.1 Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com> Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com> * [Mega-Linter] Apply linters fixes * Bump Tests Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com> Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com> Co-authored-by: TimPansino <TimPansino@users.noreply.github.com> * Add logging configuration settings. * [Mega-Linter] Apply linters fixes * Trigger tests. Co-authored-by: Timothy Pansino <11214426+TimPansino@users.noreply.github.com> Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com> Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com> Co-authored-by: TimPansino <TimPansino@users.noreply.github.com>
* Update settings for logging (HSM, harvest config) Uma Annamalai <umaannamalai@users.noreply.github.com> * [Mega-Linter] Apply linters fixes * Fix high security mode tests for application logging * [Mega-Linter] Apply linters fixes Co-authored-by: umaannamalai <umaannamalai@users.noreply.github.com> Co-authored-by: Tim Pansino <timpansino@gmail.com> Co-authored-by: TimPansino <TimPansino@users.noreply.github.com>
MegaLinter status: ❌ ERROR
See errors details in artifact MegaLinter reports on CI Job page |
* Add harvesting for log events * Fixing harvest tests * Add suggestions from code review * Fix intermittent validator failures
* Add record_log_event API Co-authored-by: Lalleh Rafeei lrafeei@users.noreply.github.com Co-authored-by: Uma Annamalai umaannamalai@users.noreply.github.com Co-authored-by: Tim Pansino timpansino@users.noreply.github.com * Fix issues with record log events tests * Fix logs in context tests * Fix python 2 syntax errors Co-authored-by: Timothy Pansino <11214426+TimPansino@users.noreply.github.com> Co-authored-by: Tim Pansino <timpansino@gmail.com>
* Add logging instrumentation Uma Annamalai umaannamalai@users.noreply.github.com * Address code review comments. * Fix testing failures Co-authored-by: Timothy Pansino <11214426+TimPansino@users.noreply.github.com> Co-authored-by: Tim Pansino <timpansino@gmail.com>
* Add loguru instrumentation * Add more loguru versions to test * Correct tox ini file * Fix missing parenthesis * Fix loguru v4 and add patching test * Patch loguru v3 support
* Add logging supportability metrics Co-authored-by: Lalleh Rafeei lrafeei@users.noreply.github.com Co-authored-by: Uma Annamalai umaannamalai@users.noreply.github.com Co-authored-by: Tim Pansino timpansino@users.noreply.github.com * Unit test adjustments Co-authored-by: Tim Pansino <timpansino@gmail.com>
* Add log fowarding handler API. * Fix pypy import
* Add application logging settings to newrelic.ini. * Comment out logging settings.
* Clean out logging testing * Add test for fixed loguru patcher forwarding * Add catch test to loguru
umaannamalai
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds first class support for log events as a new data type collected by the agent. Included with this feature is instrumentation for standard lib logging, as well as the loguru package.