Record log event #555
Merged
Record log event #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lalleh Rafeei lrafeei@users.noreply.github.com Co-authored-by: Uma Annamalai umaannamalai@users.noreply.github.com Co-authored-by: Tim Pansino timpansino@users.noreply.github.com
MegaLinter status: ❌ ERROR
See errors details in artifact MegaLinter reports on CI Job page |
| if application and application.enabled: | ||
| application.record_log_event(message, level, timestamp, priority=priority) | ||
| else: | ||
| _logger.debug( |
There was a problem hiding this comment.
Should this debug message be edited? Since record_log_event is not currently a public API that customers can use, they will not be able to supply their own application object to the call.
There was a problem hiding this comment.
I would leave it in, people will almost certainly use the API whether we make it officially public or not. Either way, it's a debug message. It might help someone or us in the future to leave it like that.
umaannamalai
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Lalleh Rafeei lrafeei@users.noreply.github.com
Co-authored-by: Uma Annamalai umaannamalai@users.noreply.github.com
Co-authored-by: Tim Pansino timpansino@users.noreply.github.com