Fix crash in route wrappers for Starlette 0.19.1 #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com> Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com>
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
lrafeei
approved these changes
Apr 26, 2022
lrafeei
added a commit
that referenced
this pull request
May 2, 2022
* Fix crash in route wrappers for starlette 0.19.1 Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com> Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com> * [Mega-Linter] Apply linters fixes * Bump Tests Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com> Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com> Co-authored-by: TimPansino <TimPansino@users.noreply.github.com>
TimPansino
added a commit
that referenced
this pull request
May 3, 2022
* Fix crash in route wrappers for Starlette 0.19.1 (#527) * Fix crash in route wrappers for starlette 0.19.1 Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com> Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com> * [Mega-Linter] Apply linters fixes * Bump Tests Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com> Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com> Co-authored-by: TimPansino <TimPansino@users.noreply.github.com> * Add logging configuration settings. * [Mega-Linter] Apply linters fixes * Trigger tests. Co-authored-by: Timothy Pansino <11214426+TimPansino@users.noreply.github.com> Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com> Co-authored-by: Uma Annamalai <umaannamalai@users.noreply.github.com> Co-authored-by: TimPansino <TimPansino@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Lalleh Rafeei lrafeei@users.noreply.github.com
Co-authored-by: Uma Annamalai umaannamalai@users.noreply.github.com
Before contributing, please read our contributing guidelines and code of conduct.
Overview
Related Github Issue
Closes #526
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
For most contributions it is strongly recommended to add additional tests which
exercise your changes.