Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safekeeper: correctly handle signals #7167

Merged
merged 1 commit into from
Mar 20, 2024
Merged

safekeeper: correctly handle signals #7167

merged 1 commit into from
Mar 20, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Mar 18, 2024

Problem

errno is not preserved in the signal handler. This pull request fixes it. Maybe related: #6969, but does not fix the flaky test problem.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested review from arssher and petuhovskiy March 18, 2024 19:11
@skyzh skyzh requested a review from a team as a code owner March 18, 2024 19:11
@skyzh skyzh requested a review from knizhnik March 18, 2024 19:11
@skyzh skyzh force-pushed the skyzh/safekeeper-handling branch from 6bba927 to d530274 Compare March 18, 2024 19:12
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/safekeeper-handling branch from d530274 to b62ad06 Compare March 18, 2024 19:13
Copy link

2700 tests run: 2569 passed, 0 failed, 131 skipped (full report)


Flaky tests (2)

Postgres 15

  • test_compute_pageserver_connection_stress: debug

Postgres 14

  • test_sharding_split_smoke: debug

Code coverage* (full report)

  • functions: 28.3% (7128 of 25166 functions)
  • lines: 46.8% (43693 of 93285 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b62ad06 at 2024-03-18T19:57:28.015Z :recycle:

Copy link
Member

@petuhovskiy petuhovskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not sure if it affects anything.

@skyzh
Copy link
Member Author

skyzh commented Mar 18, 2024

waiting for #7170

@arssher
Copy link
Contributor

arssher commented Mar 19, 2024

but I'm not sure if it affects anything.

Same, I don't think it will fix the original issue.

@skyzh skyzh enabled auto-merge (squash) March 20, 2024 18:28
@skyzh skyzh disabled auto-merge March 20, 2024 19:22
@skyzh skyzh merged commit 55c4ef4 into main Mar 20, 2024
53 checks passed
@skyzh skyzh deleted the skyzh/safekeeper-handling branch March 20, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants