Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add safekeeper team to pgxn codeowners #7170

Merged
merged 2 commits into from
Mar 20, 2024
Merged

fix: add safekeeper team to pgxn codeowners #7170

merged 2 commits into from
Mar 20, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Mar 18, 2024

Problem

pgxn/ also contains WAL proposer code, so modifications to this directory should be able to be approved by the safekeeper team.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested review from jcsp and vadim2404 March 18, 2024 20:30
@skyzh
Copy link
Member Author

skyzh commented Mar 18, 2024

@skyzh skyzh mentioned this pull request Mar 18, 2024
5 tasks
@jcsp
Copy link
Collaborator

jcsp commented Mar 18, 2024

@arssher wdyt? does it make sense to require compute team review for changes to the C code that we link into postgres, or would you like your team to be able to do these changes unilaterally?

The other side effect of this change would be that your team would get auto-assigned as reviewers for pgxn code that is unrelated to the safekeeper client code, and be responsible for either reviewing or delegating that.

@jcsp jcsp requested review from arssher and removed request for jcsp March 18, 2024 20:36
CODEOWNERS Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Mar 18, 2024

2706 tests run: 2576 passed, 0 failed, 130 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_delete_timeline_client_hangup: release

Code coverage* (full report)

  • functions: 28.3% (7132 of 25198 functions)
  • lines: 46.9% (43713 of 93290 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
28acbda at 2024-03-20T15:35:28.728Z :recycle:

@arssher
Copy link
Contributor

arssher commented Mar 19, 2024

wdyt? does it make sense to require compute team review for changes to the C code that we link into postgres, or would you like your team to be able to do these changes unilaterally?

We definitely do want to be able to make them unilaterally; if this is not the case, I just manually ask for the review.

The other side effect of this change would be that your team would get auto-assigned as reviewers for pgxn code that is unrelated

True, but there is no easy ideal solution. Even without it generally in my experience this codeowners thing quite frequently assigns unsuitable reviewers, but previous point (being able to merge without unrelated team reviews) is more important.

@arssher
Copy link
Contributor

arssher commented Mar 19, 2024

We should also add @neondatabase/safekeepers to /libs/postgres_ffi/. In fact likely this PR is caused by
#7143

skyzh and others added 2 commits March 20, 2024 10:38
@skyzh skyzh enabled auto-merge (squash) March 20, 2024 18:28
@skyzh skyzh merged commit 5f0d9f2 into main Mar 20, 2024
53 checks passed
@skyzh skyzh deleted the skyzh-patch-1 branch March 20, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants