Skip to content

Commit

Permalink
safekeeper: correctly handle signals (#7167)
Browse files Browse the repository at this point in the history
errno is not preserved in the signal handler. This pull request fixes
it. Maybe related: #6969, but
does not fix the flaky test problem.

Signed-off-by: Alex Chi Z <chi@neon.tech>
  • Loading branch information
skyzh authored Mar 20, 2024
1 parent 5f0d9f2 commit 55c4ef4
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pgxn/neon/walproposer_pg.c
Original file line number Diff line number Diff line change
Expand Up @@ -549,9 +549,10 @@ walprop_pg_init_standalone_sync_safekeepers(void)
static void
walprop_sigusr2(SIGNAL_ARGS)
{
int save_errno = errno;
got_SIGUSR2 = true;

SetLatch(MyLatch);
errno = save_errno;
}

static void
Expand Down

1 comment on commit 55c4ef4

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2786 tests run: 2643 passed, 1 failed, 142 skipped (full report)


Failures on Postgres 14

  • test_bulk_insert[neon-github-actions-selfhosted]: release
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_bulk_insert[neon-release-pg14-github-actions-selfhosted]"
Flaky tests (1)

Postgres 16

  • test_vm_bit_clear_on_heap_lock: debug

Code coverage* (full report)

  • functions: 28.3% (7136 of 25210 functions)
  • lines: 46.9% (43724 of 93293 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
55c4ef4 at 2024-03-20T20:59:10.336Z :recycle:

Please sign in to comment.