Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore gaps in links underline in iOS 8+ and Safari 8+ #693

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

antons
Copy link
Contributor

@antons antons commented Aug 13, 2017

#573 introduced the change. I propose to revert it, because:

  1. It breaks iOS and macOS platform conventions: underlines are always drawn with “ink” style in native text views.
  2. It’s a step back for web typography. Apple intentionally set the browser default to “ink” to make underlined text more readable.
  3. The lack of this rule doesn’t affect other browsers, but its presence is harmful.

@jonathantneal
Copy link
Contributor

@antons, thanks for this PR. I hope it gets merged! I think we should always fall forward.

Link to the draft spec: https://drafts.csswg.org/css-text-decor-4/#text-decoration-skip-ink-property
Link to Chrome status: https://www.chromestatus.com/feature/5631679087509504

@necolas necolas merged commit ff155ff into necolas:master Feb 8, 2018
@necolas
Copy link
Owner

necolas commented Feb 8, 2018

Merged ff155ff

@antons
Copy link
Contributor Author

antons commented Feb 10, 2018

Thanks! Happy to see this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants