Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gaps in links underline in iOS 8+ and Safari 8+ #573

Merged
merged 1 commit into from
Apr 11, 2016

Conversation

hudochenkov
Copy link
Contributor

Remove gaps in links underline in iOS 8+ and Safari 8+

This gaps presented in Safari and iOS only. They were added in Safari 8 and iOS 8 but CrossBrowserTesting show them even in Safari 6.

CodePen without fix and results.

screen shot 2016-04-08 at 21 33 08

CodePen with fix and results.

screen shot 2016-04-08 at 21 33 10

@jonathantneal
Copy link
Contributor

I think this change is intentional.

https://css-tricks.com/almanac/properties/t/text-decoration-skip/
https://medium.com/designing-medium/crafting-link-underlines-on-medium-7c03a9274f9#.64aes54bm

Which is happy and sad. Happy because it improves readability of text. Sad because this is one of the most perfect PRs I’ve seen.

@hudochenkov
Copy link
Contributor Author

Thank you for the kind words :)

I think removing these gaps is making link underlines consistent between browsers which is the main purpose of normalize.

@jonathantneal
Copy link
Contributor

You are correct that normalize.css is about making things consistent, but not necessarily to the lowest common denominator. For instance, normalize.css v1 would not have added * { box-shadow: none !important; } to prevent browsers from looking different from IE8. The exception to this rule was when the property impacted the box model. For instance, Firefox used to have a line height on inputs that could not be overridden, so normalize.css prevented all browsers from changing this.

However, I need to look into this further, because the spec indicates that the default is objects, while Safari is defaulting to ink.

@thierryk
Copy link

I think it would make more sense to "normalize" this using the initial value (objects) rather than none.

@jonathantneal
Copy link
Contributor

@hudochenkov, if you would be open to modifying your commit to change none to objects, I would take in this PR for 4.1.0.

@hudochenkov
Copy link
Contributor Author

@jonathantneal I updated commit. Codepen with example.

@jonathantneal jonathantneal merged commit 8ed3140 into necolas:master Apr 11, 2016
@jonathantneal
Copy link
Contributor

@hudochenkov, @thierryk, thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants