Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 64 uses "text-decoration-skip-ink: auto" by default #722

Closed
AlekseyMartynov opened this issue Jan 30, 2018 · 6 comments
Closed

Chrome 64 uses "text-decoration-skip-ink: auto" by default #722

AlekseyMartynov opened this issue Jan 30, 2018 · 6 comments

Comments

@AlekseyMartynov
Copy link

https://www.chromestatus.com/feature/5631679087509504

Looks like this:

ink

If #693 is approved then nothing needs to be changed.
Otherwise text-decoration-skip-ink: none can be added to remove the skips.

@necolas
Copy link
Owner

necolas commented Feb 8, 2018

#693 was merged. Thanks

@necolas necolas closed this as completed Feb 8, 2018
@missmatsuko
Copy link

I would actually have preferred to set the default text-decoration-skip-ink style on links as 'none' for a couple reasons:

  1. Leaving it up to the browser results in a number of different skip behaviours across all modern browsers, which I think defeats the purpose of using normalize.

Edge, IE, and Firefox won't have any gaps. Chrome uses 'ink' and has gaps on descenders. Safari uses 'skip' and has gaps, but I'm not sure if the behaviour is the same as 'ink' on Chrome.

  1. Skipping text decoration on descenders (as Chrome now does by default) can make a single text link look like multiple text links. I think text-decoration-skip can be a nice typographic treatment for non-interactive text, but I don't think it should be applied by default to all links.

screen shot 2018-03-05 at 4 58 47 pm

@natewind
Copy link

natewind commented Apr 7, 2018

Agreed. Especially since there is already a way to make link underlines look pretty — by using border-bottom:
image

@tomasz1986
Copy link

tomasz1986 commented Apr 7, 2018

Agreed. Especially since there is already a way to make link underlines look pretty — by using border-bottom:

border-bottom breaks if a link spans over multiple lines though (i.e only the very bottom line has a border).

@missmatsuko
Copy link

@tomasz1986 That's not true for inline elements (like anchors are by default).

This post has some examples of ways to style "underlines":
https://css-tricks.com/styling-underlines-web/

@tomasz1986
Copy link

That's not true for inline elements (like anchors are by default).

I stand corrected. I got confused when trying to use border-bottom on anchors set to inline-block and did not re-test it with default CSS properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants