Fix:android:64 bit and cleanup2 #877

jandegr · 2019-09-19T13:47:20Z

A cleaned version as a followup on
#863

Many more fixes to do but I have to draw a line from time to time

after this you may have to set autobrief on doxygen if not already so
If the JAVADOC_AUTOBRIEF is set to YES then doxygen will interpret the first line (until the first dot) of a JavaDoc-style comment as the brief description.

fixes #828
fixes #832
fixes #550

* fix android 64 * Update gslice.c * cosmetic * some changes ported from iOS 32 * Update fake.h * Update checkstyle.xml * Update checkstyle.xml * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Update checkstyle.xml * Update checkstyle.xml * Update checkstyle.xml * style fixes * fix access * Add files via upload * don't litter recent devices * one more attempt to fix JLS * Add files via upload * Add files via upload * JLS * style issues * Update checkstyle.xml * style issues * style issue * Add files via upload * Add files via upload * Add files via upload * Update checkstyle.xml * style issues * Add files via upload * style issues * style issues * style issues * style issues * Update checkstyle.xml * style issues * style issues * style issues * style issues * style issues * style issues * style issues * style issues * style issues * style issues * style issues * style issues * style issues * Add files via upload * Update checkstyle.xml * style issues * Add files via upload * Add files via upload * Add files via upload * Update NavitVehicle.java * Update build.gradle * Update config.yml * style issues * style issues * style issues * style issues * style issues * style issues * style issues * style issues * style issues * style issues * style issues * style issues * style issues * style issues * style issues * doc style test * another doc style test * style issues * style issues * style issues * style issues * style issues * style issues * style issues * style issues * style issue * Add files via upload * Update build.gradle * Update build.gradle * fixes * fixes * fixes * fixes * cleanup * fixes * cleanup * cleanup * navitUtils * cleanup * fixes * fixes * test for cyclomatic complexity * test * cyclomatic complexity * test ontouch * further test onTouch * test onTouch * test onTouch * test onKeyDown * onKeyUp * handlerissue * cleanup * indent * make error default * indent * test onKeyDown * test onKeyDown * test callbackMessageChannel * test callBackMessageChannel * Update AndroidManifest.xml * test * test * more test * Update android.c * more test * more test * Add files via upload * fixes * Create test_junk.c * Create test_junk2.c * Update test_junk2.c * Update test_junk2.c * Update test_junk.c * Update test_junk2.c * Update test_junk.c * Update test_junk.c * Update test_junk.c * Update test_junk.c * Delete test_junk2.c * Delete test_junk.c * fixes * fixes * fixes * fixes * fixes * fixes * fixes * AOSPfixes * fixes * fixes * fixes * Add files via upload * fixes * switch break style * fixes * fixes * fixes * Update checkstyle.xml * fixes * style fixes * style fixes * cleanup * cleanup * cleanup * fix & pedestrian preliminary * whitespace * revert * lineendings * fixes and keyboard * fixes and keyboard * fixes and keyboard * pedestrian plugin * ROLL for pedestrian plugin * cleanup * cleanup * cleanup * fix mistake in commit for pedestrian plugin * keyboard * fixes * remove sdk version * fixes * fixes * fixes * fixes * fixes * whitespace * fixes * fixes * whitsepace

was a leftover from the pedestrian plugin test

jandegr · 2019-09-22T06:02:05Z

a test on a MI A2 with STF

* part of pr 812 (send geo intent) * fixes

jandegr · 2019-09-24T15:10:44Z

Hi,
Solved the merge conflict and included the "send geo intent" part of #812 all credits to @lains

STF @pgrandin is quite slow right now, so the screenshot is from a local jellybean device this time,
showing the selection popup after launching a geo intent from Navit.

@lains sending an intent works flawless, I just had the impression smth in #812 is only 95% identical to #794 but I could not resist testing it. Manifest already registers Navit as a receiver but obviously that won't work yet since the code itself is not included, but I tweaked the sending part so that it requires more than one receiving app to prevent sent intents from just being looped back to Navit. What are your thoughts about all of this ?

lains · 2019-09-25T07:35:00Z

@lains sending an intent works flawless, I just had the impression smth in #812 is only 95% identical to #794 but I could not resist testing it. Manifest already registers Navit as a receiver but obviously that won't work yet since the code itself is not included, but I tweaked the sending part so that it requires more than one receiving app to prevent sent intents from just being looped back to Navit. What are your thoughts about all of this ?

@jandegr, yes you're perfectly right. #794 (now merged) was already containing features that were re-used for #812.
I am planning to merge #812 soon, so that you can rebase on trunk... and you're right also that looping geo: view intents back to navit is not a good thing...

lains · 2019-09-25T07:54:20Z

@jandegr,

shall Add/Android Supporting sending & receiving geo: intents #812 be squash-merged and you rebase on trunk?
or do you want to submit Fix:android:64 bit and cleanup2 #877 containing all changes

I'd rather got for option 1, since option 2 maybe not as good because in the history, both features will be mixed, which makes it more difficult to debug.

#812 is ready for merge to trunk, and it seems you already reviewed the code, so if that PR is OK for you, please post me review comment on #812 and I'll merge.

* cleanup

jandegr · 2019-09-25T09:17:07Z

Hi @lains
You're completely free to handle it as you want, this pr just shows how I think things can be handled and I doubt any of it will make it into trunk as such. In the case of the geo intent sending I just showed it in advance instead of waiting until it was committed.

* Update coord.h * remove receive geo intent * whitespace * change receiver check

jandegr · 2019-09-26T10:50:11Z

Hi,

By now I started reworking other stuff so I did a final and last commit on this PR.
Removes receiving geo intents, that was very interesting and gave a preview of what issues to expect so I limited it to sending geo intents for now (credit to @lains).
And some last minor cleanup.

Known issues

colors in the filebrowseractivity not ok on android 2.3 as reported by @jkoan
fullscreen to be reviewed
in landscape mode the native keyboard leaves little room for gui_internal, removing the numerical bar could improve things a bit.

The system bars become solid instead of transparent while dragging the map, a limitation of graphics not being informed by navit that it changes from mapview to gui_internal, subject to improvement.

Reanimating the pedestrian plugin needs more work.
Several other improvements and fixes of mostly longstanding issues were not handled and could be done in smaller PR's.

Testing was done

locally on 4 devices and 3 AVD's
2 devices on Kobiton
2 devices on STF @pgrandin THX!
several tests done by @jkoan THX!

Fixes all 327 of https://17312-30791823-gh.circle-artifacts.com/0/reports/checkstyleMain.html

Bumps it from B to A- on codefactor, but at the rate new issues are created that won't last long.

pgrandin

impressive fixes and cleanup. Thank you @jandegr !

#877

navit-gps#877

jandegr added 2 commits September 19, 2019 14:59

minor cleanup

bd2ced6

jandegr marked this pull request as ready for review September 19, 2019 13:58

This was referenced Sep 19, 2019

android:fix mapdownload #856

Closed

fix crosscompilation without PkgConfig #854

Closed

remove permission camera

7bdbc29

was a leftover from the pedestrian plugin test

jkoan approved these changes Sep 22, 2019

View reviewed changes

jandegr added 2 commits September 24, 2019 06:57

Merge branch 'trunk' into fix_android_64

67251d1

Fix android 64 2 (#65)

195915c

* part of pr 812 (send geo intent) * fixes

cleanup (#66)

b4eeb03

* cleanup

jandegr and others added 3 commits September 25, 2019 11:38

Merge branch 'trunk' into fix_android_64

f063218

Merge branch 'trunk' into fix_android_64

84db619

final (#67)

9b5744e

* Update coord.h * remove receive geo intent * whitespace * change receiver check

jandegr mentioned this pull request Sep 26, 2019

Add/Android Supporting sending & receiving geo: intents #812

Merged

jkoan self-requested a review September 26, 2019 11:29

jkoan approved these changes Sep 26, 2019

View reviewed changes

pgrandin approved these changes Sep 26, 2019

View reviewed changes

pgrandin merged commit d18dec5 into navit-gps:trunk Sep 26, 2019

jandegr deleted the fix_android_64 branch September 29, 2019 06:33

jandegr mentioned this pull request Sep 29, 2019

Fix:Android:system bars #890

Merged

mvglasow mentioned this pull request Oct 10, 2019

Android notification bar covers part of content #904

Closed

jandegr mentioned this pull request Oct 11, 2019

Android:fix SD card storage #548

Open

mvglasow mentioned this pull request Oct 11, 2019

Changed default path for custom navit.xml #907

Open

aerostitch added the android label Oct 29, 2019

viktorgino pushed a commit that referenced this pull request Sep 22, 2020

Fix:android:64 bit and cleanup2 (#877)

74487e4

#877

jkoan pushed a commit to jkoan/navit that referenced this pull request Jun 30, 2021

Fix:android:64 bit and cleanup2 (navit-gps#877)

1840c7a

navit-gps#877

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix:android:64 bit and cleanup2 #877

Fix:android:64 bit and cleanup2 #877

jandegr commented Sep 19, 2019 •

edited

Loading

jandegr commented Sep 22, 2019

jandegr commented Sep 24, 2019 •

edited

Loading

lains commented Sep 25, 2019

lains commented Sep 25, 2019 •

edited

Loading

jandegr commented Sep 25, 2019

jandegr commented Sep 26, 2019 •

edited

Loading

pgrandin left a comment

Fix:android:64 bit and cleanup2 #877

Fix:android:64 bit and cleanup2 #877

Conversation

jandegr commented Sep 19, 2019 • edited Loading

jandegr commented Sep 22, 2019

jandegr commented Sep 24, 2019 • edited Loading

lains commented Sep 25, 2019

lains commented Sep 25, 2019 • edited Loading

jandegr commented Sep 25, 2019

jandegr commented Sep 26, 2019 • edited Loading

pgrandin left a comment

Choose a reason for hiding this comment

jandegr commented Sep 19, 2019 •

edited

Loading

jandegr commented Sep 24, 2019 •

edited

Loading

lains commented Sep 25, 2019 •

edited

Loading

jandegr commented Sep 26, 2019 •

edited

Loading