Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Android Navit64 #863

Closed
wants to merge 63 commits into from
Closed

Conversation

jandegr
Copy link
Contributor

@jandegr jandegr commented Sep 3, 2019

fixes #828

acts upon #832

@jandegr
Copy link
Contributor Author

jandegr commented Sep 3, 2019

Codefactor 52 issues reported as fixed, 84 reported as new despite only 2 of them actually are introduced by this PR.
I will fix a bunch more tomorrow or so.

@jkoan
Copy link
Member

jkoan commented Sep 14, 2019

With this fix Navit finally works again on arm64 (Oneplus 3t)
Nice work!
Do you want to add anything to this, or is it ready to merge? Its still on WIP/Draft Status. And Codefactor is not a Merge blocker for us.
Thank you really much for your work 😄

* Update build.gradle

* Update config.yml

* style issues

* style issues

* style issues

* style issues

* style issues

* style issues

* style issues

* style issues

* style issues

* style issues

* style issues

* style issues

* style issues

* style issues

* style issues

* doc style test

* another doc style test

* style issues

* style issues

* style issues

* style issues

* style issues

* style issues

* style issues

* style issues

* style issue

* Add files via upload

* Update build.gradle

* Update build.gradle

* fixes

* fixes

* fixes

* fixes

* cleanup

* fixes

* cleanup

* cleanup

* navitUtils

* cleanup

* fixes

* fixes

* test for cyclomatic complexity

* test

* cyclomatic complexity

* test ontouch

* further test onTouch

* test onTouch

* test onTouch

* test onKeyDown

* onKeyUp

* handlerissue

* cleanup

* indent

* make error default

* indent

* test onKeyDown

* test onKeyDown

* test callbackMessageChannel

* test callBackMessageChannel

* Update AndroidManifest.xml

* test

* test

* more test

* Update android.c

* more test

* more test

* Add files via upload

* fixes

* Create test_junk.c

* Create test_junk2.c

* Update test_junk2.c

* Update test_junk2.c

* Update test_junk.c

* Update test_junk2.c

* Update test_junk.c

* Update test_junk.c

* Update test_junk.c

* Update test_junk.c

* Delete test_junk2.c

* Delete test_junk.c

* fixes

* fixes

* fixes

* fixes

* fixes

* fixes

* fixes

* AOSPfixes

* fixes

* fixes

* fixes

* Add files via upload

* fixes

* switch break style

* fixes

* fixes

* fixes

* Update checkstyle.xml

* fixes

* style fixes

* style fixes

* cleanup

* cleanup

* cleanup

* fix & pedestrian preliminary

* whitespace

* revert

* lineendings
@jandegr
Copy link
Contributor Author

jandegr commented Sep 16, 2019

Hi,
I finally got to add the next batch.

@jkoan thx for testing.
Since you also tested the glib part of this pr #851 there is no doubt about your phone, but if somebody else wants to test pls. report the flavor that is added in the gui_internal about page.
All testing is usefull but it gets even more meaning if the flavor is reported as well.

THX

@jandegr jandegr mentioned this pull request Sep 16, 2019
@jandegr
Copy link
Contributor Author

jandegr commented Sep 16, 2019

@metalstrolch
Thx for looking into this POC.
I can't do CARVED_IN_STONE = askaround() but since doc would be appropriate there
https://github.com/navit-gps/navit/blob/trunk/navit/android.c#L70
it would be a good place to add a reference to the CMAKE fixed equivalent.

thx.

@jkoan
Copy link
Member

jkoan commented Sep 16, 2019

I did a quick test with all the other test devices i have lieing around:

apk file: 7b85978912d2dd5b575a32027d2ef672
build: https://app.circleci.com/jobs/github/jandegr/navit/5168/artifacts

armeabi-v7a (Huawei Y300-0100) working ✔️
armeabi-v7a (Sony C1505) working ✔️
armeabi-v6l (LG-P690) not working ❌ Android 4.1.2 cyanogenmod 10-20121222-UNOFFICIAL-p690 : Couldn't load navit: findLibrary returned null
armeabi (Samsung GT-S6802) not working ❌ Android 2.3.6 : error while installing Failure [INSTALL_FAILED_CPU_ABI_INCOMPATIBLE]
armeabi-v7a (Sony LT22i) working ✔️ Android 4.1.2

@jandegr
Copy link
Contributor Author

jandegr commented Sep 16, 2019

Hi,
@jkoan
this apk includes all ABI's still supported today
ndk { abiFilters 'x86', 'x86_64', 'arm64-v8a', 'armeabi-v7a' }
We used to have the older flavor armeabi with one of the old buildscripts, they deleted those from the repo but I think you can still find them.
Support for those was dropped in ndk 17, so use 16b. Minsdk is 9 so that will be ok.

https://developer.android.com/ndk/guides/abis

thx again for testing again :)

@jkoan
Copy link
Member

jkoan commented Sep 18, 2019

@jandegr could you give a todo list for this PR whats left to do until we can finaly Rewiew this really nice work and ship it into the coming release?

@jandegr
Copy link
Contributor Author

jandegr commented Sep 18, 2019

@jkoan
after the last update did

  • minor cleanup / rework
  • fix a regression I introduced for KITKAT
  • tested the pedestrian plugin for regressions
  • reworked native keyboard, complete upto KITKAT for all orientations and in portrait for versions > KITKAT

todo

  • fix native keyboard for versions > KITKAT in landscape orientation
  • look into a detail when backgrounded or lost focus
  • fullscreen mode to revisit
  • etc...
  • fix a few household matters with @pgrandin

The lowhanging fruit in the fixes is gone, remaining fixes seem to take longer and longer...

@jandegr
Copy link
Contributor Author

jandegr commented Sep 19, 2019

closing this since #876 contains the latest updates

@jandegr jandegr closed this Sep 19, 2019
@jandegr jandegr deleted the android64_test branch September 25, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

navit crashes on android 9, SDK 28, ABI arm64-v8a
3 participants