Add/Android Supporting sending & receiving geo: intents

[lains]

This PR adds 2 features to navit for Android:

• When a geo: intent is started on Android, for example by scanning a geo QR code, navit is able to takes these coordinates as input

• When a specific point is clicked on the map, this PR adds a new item in the contextual menu: "View". By clicking on that item (and if there are applications to handle it) a geo intent is generated in Android

[lains]

Hi @jandegr, I could not reproduce the issue, but I'm sure I've noticed before this feeling of multiple instances running.
I have implemented the changes you suggested, and the singleTask is indeed a singleton, so this is probably what is needed.
Please let me know if this new version of the code fixes it.

[lains]

I could not reproduce the issue, but I'm sure I've noticed before this feeling of multiple instances running.

Actually, I just reproduced the issue on a Samsung device running Android 4.4.2.
And there, it seems fixed by the singleTask launch mode...

[lains]

And I also restested the intent loopback issue (crash) after I rebased on the code from trunk including PR877 and it did not crash. So, I think you already fixed the crash in that PR.

[jandegr]

I will take some time to test it soon, but even without testing I suspect it now indeed sticks to being a singleton, but since you did not implement onNewIntent(), it will just recreate navit and that is not what we want. I might be wrong, but I just think it will now show in the log it takes the onCreate() route (or maybe, but probably not, the onRestart() route) since you don't open the onNewIntent entrypoint. At least it is what the API makes me think.

THX

[lains]

I did some additional testing, and the execution flow actually doesn't go through onCreate() but it is even worse because the intent now is not handled properly.

When navit is initially started from a geo intent, the sequence is:

onCreate()
**1**A android.intent.action.VIEW
**1**D geo:48.709807,15.193542
OnStart()
OnResume()
**2**A android.intent.action.VIEW
**2**D geo:48.709807,15.193542
target found (b): 48.709807,15.193542

But when navit is already running and resumed with a new geo intent, we go through:

OnRestart()
OnStart()

But does not take the intent into account... it keeps the previous destination, if any, so the intent reception feature is actually not working properly anymore.
I'll have a look into this. Probably, as suggested, I need to implement onNewIntent() and also decode the intent there... and do as what is currently done inside onCreate() (intent is cached inside member variable sStartupIntent, then processed later on in onResume())

To be continued...

[lains]

I have tested on this new code and receiving a geo intent now works as expected (starts navigating to the coordinates provided) even when navit is already running.
If navit was inside a menu when the intent is received, it remains inside that menu. Not sure whether this should be kept like that or if map should be displayed immediately and current menu dropped.

I am already planning to build some future work on this code base, opening a contextual menu based on the geolocation extracted from the intent, so that the exact action to perform on the input coordinates can be selected by the user, exactly the same way as when coordinates are input using the Action>Coordinates menu in the internal GUI...
But I would rather not add more code to the current PR and handle this in a future PR as explained in a previous comment.

@jandegr already told me sending geo intents is working but I fixed receiving geo intents since then, so I'd be happy if someone can test and give me feedback on this feature.

Shall I merge?

Thanks!

[jandegr]

Hi,
There are failing scenario's for the existing google.navigation intent in the existing codebase and your work just inherits those.
There are several ways to deal with this and the way that not turns this into an endless story for you is you commit this and I will apply the fixes afterwards together with some other rework. You will see some of your lines being shuffled around afterwards.
The other way is you change all of it into a solution working in every scenario for both the intents.

your choice.

[jandegr]

@lains pls. merge this since future work depends on it.
After merging I can post another (but smaller this time) Android rework and then you can proceed with the future extensions you mentioned whenever it suits you.

THX

[lains]

Great. Thanks @pgrandin for merging this.
@jandegr, yes, I will wait for #919 before doing further work on the view intent.